From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6671EC4167B for ; Fri, 25 Nov 2022 11:59:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230174AbiKYL7I (ORCPT ); Fri, 25 Nov 2022 06:59:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbiKYL66 (ORCPT ); Fri, 25 Nov 2022 06:58:58 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 962BC2C65E for ; Fri, 25 Nov 2022 03:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669377486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=18eKkqzY4QfZggnhIBrTnwfUuxA6G9dwStlUaTlx9d0=; b=L0/2Rh23bK9VikUCwwVghPdG8XVOJBUGS1f6pjzarIUHCgy4FnEeT95mbAlc/bIODsgXPX YVrtFIbHLRrCMkCYSI6w310a8CdFdvsGR8nOSKvjGkVafvDWh+YqP7NUmKWm1MFx8iajgb XgtIFnpcepWHpmdsgewwOGjcc7yd+Ms= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-3-LrOTnjvLPa21Y1TGscRZPA-1; Fri, 25 Nov 2022 06:58:02 -0500 X-MC-Unique: LrOTnjvLPa21Y1TGscRZPA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4A4BE858F17; Fri, 25 Nov 2022 11:58:02 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id F07601415121; Fri, 25 Nov 2022 11:58:00 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20221124034212.81892-2-jefflexu@linux.alibaba.com> References: <20221124034212.81892-2-jefflexu@linux.alibaba.com> <20221124034212.81892-1-jefflexu@linux.alibaba.com> To: Jingbo Xu Cc: dhowells@redhat.com, jlayton@kernel.org, xiang@kernel.org, chao@kernel.org, linux-cachefs@redhat.com, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/2] fscache,cachefiles: add prepare_ondemand_read() callback MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2386960.1669377478.1@warthog.procyon.org.uk> Date: Fri, 25 Nov 2022 11:57:58 +0000 Message-ID: <2386961.1669377478@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jingbo Xu wrote: > Add prepare_ondemand_read() callback dedicated for the on-demand read > scenario, so that callers from this scenario can be decoupled from > netfs_io_subrequest. > > The original cachefiles_prepare_read() is now refactored to a generic > routine accepting a parameter list instead of netfs_io_subrequest. > There's no logic change, except that the debug id of subrequest and > request is removed from trace_cachefiles_prep_read(). > > Reviewed-by: Jeff Layton > Signed-off-by: Jingbo Xu Acked-by: David Howells