From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262026AbUKPQM6 (ORCPT ); Tue, 16 Nov 2004 11:12:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262025AbUKPQM6 (ORCPT ); Tue, 16 Nov 2004 11:12:58 -0500 Received: from mx1.redhat.com ([66.187.233.31]:63196 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S262021AbUKPQMB (ORCPT ); Tue, 16 Nov 2004 11:12:01 -0500 From: David Howells In-Reply-To: References: <20968.1100619491@redhat.com> To: Linus Torvalds Cc: akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: fork pagesize patch User-Agent: EMH/1.14.1 SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386-redhat-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Date: Tue, 16 Nov 2004 16:11:46 +0000 Message-ID: <23880.1100621506@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > Please don't do that. What you've done causes a divide-by-zero error to be > > emitted by the compiler if PAGE_SIZE > THREAD_SIZE. That's why I used the > > preprocessor in the first place. > > What kind of broken compiler are _you_ using? Fix your compiler. Sorry... I meant warning not error. It doesn't actually stop it building a working kernel, but gcc _does_ complain, and not unreasonably, I think. David