Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

Detlev Casanova
2025-02-25T14:59:41Z

Hi Morimoto-san,

On Tuesday, 25 February 2025 01:16:50 EST Kuninori Morimoto wrote:
> Hi Detlev, again
>
> > > Especially those commits:
> > > ASoC: audio-graph-card2: use __free(device_node) for device node
> > > ASoC: audio-graph-card: use __free(device_node) for device node
> > > ASoC: simple-card: use __free(device_node) for device node
> >
> > I got same report from our test team. I'm now tring to solve it.
>
> Unfortunately, I can't reproduce the issue on my environment,
> but I guess I found the root cause. Does attached patch can solve
> your issue ?

From what I see, the error is not present anymore on linux 6.14-rc4. I tried
reverting your patch "ASoC: simple-card-utils.c: add missing dlc->of_node"
(dabbd325b25edb5cdd99c94391817202dd54b651) and the error reappears.

On 6.14-rc3, any of your patches (dabbd325b25e, or the one you attached here)
will fix the issue and on 6.14-rc4, there is already a patch that fixes the
issue.

Also, since dabbd325b25e, the node indeed should be kept while the driver is
used. So even though the issue reported here is fixed by another patch, both
are likely needed.

That being said, I'm not sure I completely understand why that extra line fixes
the issue. Is the __free() attribute smart enough to know that the pointer has
been copied and not free it at the end of scope ?

> I will officially post the patch to ML, but want to confirm it before it.
>
> Thank you for your help !!

Thank you for looking into this too :)

Detlev.