Re: [PATCH 01/13] dt-bindings: net: rockchip-dwmac: Fix rockchip,rk3308-gmac compatible

Paolo Abeni
2024-05-23T11:40:04Z

On Tue, 2024-05-21 at 23:34 +0200, Heiko Stübner wrote:
> Am Dienstag, 21. Mai 2024, 23:10:04 CEST schrieb Jonas Karlman:
> > Schema validation using rockchip,rk3308-gmac compatible fails with:
> >
> > ethernet@ff4e0000: compatible: ['rockchip,rk3308-gmac'] does not contain items matching the given schema
> > from schema $id: http://devicetree.org/schemas/net/rockchip-dwmac.yaml#
> > ethernet@ff4e0000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts', 'phy-mode',
> > 'reg', 'reset-names', 'resets', 'snps,reset-active-low', 'snps,reset-delays-us',
> > 'snps,reset-gpio' were unexpected)
> > from schema $id: http://devicetree.org/schemas/net/rockchip-dwmac.yaml#
> >
> > Add rockchip,rk3308-gmac to snps,dwmac.yaml to fix DT schema validation.
> >
> > Fixes: 2cc8c910f515 ("dt-bindings: net: rockchip-dwmac: add rk3308 gmac compatible")
> > Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> I'm not sure how the network tree works these days, but this patch is the
> only one that should go through the network tree.

It looks like the rest of the series has no dependency and will be
merged
via other trees.

If so, I think it would be cleaner if you could submit this patch
individually to the net tree, including the target tree 'net' into the
subj.

That will trigger successfully our CI - that currently does little for
DT changes but still more then nothing and things could improve in the
future.

Thanks,

Paolo