From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1033983AbbKFWQG (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Nov 2015 17:16:06 -0500
Received: from v094114.home.net.pl ([79.96.170.134]:48607 "HELO
	v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with SMTP id S1030347AbbKFWQE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Nov 2015 17:16:04 -0500
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>, stern@rowland.harvard.edu,
        linux-pm@vger.kernel.org, Len Brown <len.brown@intel.com>,
        Pavel Machek <pavel@ucw.cz>, linux-kernel@vger.kernel.org,
        Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v2] PM / sleep: prohibit devices probing during suspend/hibernation
Date: Fri, 06 Nov 2015 23:45:17 +0100
Message-ID: <2393767.8Sl5edZvSi@vostro.rjw.lan>
User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20151106020745.GA24550@kroah.com>
References: <1445288064-25299-1-git-send-email-grygorii.strashko@ti.com> <5530449.00gvFOj9K4@vostro.rjw.lan> <20151106020745.GA24550@kroah.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, November 05, 2015 06:07:45 PM Greg Kroah-Hartman wrote:
> On Fri, Nov 06, 2015 at 03:04:10AM +0100, Rafael J. Wysocki wrote:
> > On Thursday, November 05, 2015 04:09:57 PM Greg Kroah-Hartman wrote:
> > > On Thu, Nov 05, 2015 at 11:38:23PM +0100, Rafael J. Wysocki wrote:
> > > > On Monday, November 02, 2015 02:25:00 AM Rafael J. Wysocki wrote:
> > > > > On Monday, October 19, 2015 11:54:24 PM Grygorii Strashko wrote:
> > > > > > It is unsafe [1] if probing of devices will happen during suspend or
> > > > > > hibernation and system behavior will be unpredictable in this case
> > > > > > (for example: after successful probe the device potentially has a different
> > > > > >  set of PM callbacks than before [2]).
> > > > > > So, let's prohibit device's probing in dpm_prepare() and defer their
> > > > > > probes instead. The normal behavior will be restored in dpm_complete().
> > > > > > 
> > > > > > This patch introduces new DD core APIs:
> > > > > >  device_defer_all_probes_enable()
> > > > > >    It will disable probing of devices and defer their probes.
> > > > > >  device_defer_all_probes_disable()
> > > > > >    It will restore normal behavior and trigger re-probing of deferred
> > > > > >    devices.
> > > > > > 
> > > > > > [1] https://lkml.org/lkml/2015/9/11/554
> > > > > > [2] https://lkml.org/lkml/2015/9/15/1039
> > > > > > Cc: Alan Stern <stern@rowland.harvard.edu>
> > > > > > Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> > > > > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > > > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > > > > 
> > > > > Greg, any objections against this one?
> > > > 
> > > > Greg, if this isn't problematic, I'd still like to take it for v4.4.
> > > 
> > > What?  The merge window for new stuff closed a few weeks ago, how can
> > > you add this for 4.4 when it needs to be in linux-next for a while
> > > first?
> > 
> > Well, it's not really scary and it was posted way before the merge window,
> > but no one has had the time to look at it since then, apparently.
> > 
> > Of course, I can queue it up for the next release too.
> 
> That would be best, thanks.

OK