From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx-relay90-hz2.antispameurope.com (mx-relay90-hz2.antispameurope.com [94.100.136.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7C21280309 for ; Tue, 2 Dec 2025 11:49:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=94.100.136.190 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764676146; cv=pass; b=bIKHilo+Bcf17WF+3NV5jXqbIjMo0xlaN4ysP0DrscAgrSSFL02jkKfoOloi4m8QEUMthhqRH/a5CgIRyYn7l4THq9Bby4D5q0C07ZbwN6/kZ9WSrIQ3w9faWwX2DPsKnr+GzmuwWEk8TGvs/7Do8Lr8dksWBK4bD6oCVNIqi4A= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764676146; c=relaxed/simple; bh=rOAoEjyVa1jEQA2BYDgvgv+WUqVYhkDMhJXVPZnWjU8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I7trDBKkj3iTFDhlDNUNu5WXGzEM9VF+0XVt8nAS7nCUg6v0omHMYpoXNVSFsV+staraOq/xi3MTa4c+GV4SvFsAPrE++bPuNUQc1QLoVn7pacKghDy3UFqp+fG5BWnteZYR9TkC5p389ONF8ntL0m+i/UfoHSvBbrm2UdZ8+iQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=RQ/9kv7+; arc=pass smtp.client-ip=94.100.136.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="RQ/9kv7+" ARC-Authentication-Results: i=1; mx-gate90-hz2.hornetsecurity.com 1; spf=pass reason=mailfrom (ip=94.100.132.6, headerfrom=ew.tq-group.com) smtp.mailfrom=ew.tq-group.com smtp.helo=smtp-out01-hz1.hornetsecurity.com; dmarc=pass header.from=ew.tq-group.com orig.disposition=pass ARC-Message-Signature: a=rsa-sha256; bh=cPzBCQ/cVroc4yKwXafobMdff4xUZ/bh1Bgq00vprqk=; c=relaxed/relaxed; d=hornetsecurity.com; h=from:to:date:subject:mime-version:; i=1; s=hse1; t=1764676111; b=hFlVdkiTukhRS+gtH3OXiALh1xMZ0HwBoeno6i5AJvluZi7Fuhw5iB/B9vCfSsg65s0YS2Qp AG0OUsFty/J0Bjy4o4cF+oF+Xp+9yYXhIknPOx4mBaLPEQPciOgZ559Gl5XDv8GHNR7kB0yVS9j E8UcWsoHTt+Nc2odib5ei4w9U8/ithC2y3jCSmQPkwfnFJYFMtviaX4oXGfXSejAs0OS+dS2ezb I1YzykCr3YPN7j9XrZJC+JO7im3dGr/y0jecmjk9tFPfYE4KeLSZsuuyEX5AMDIRfBrtzjTcXYf A4rXY9kDxxWWN1Y7e0/Z7fv/kuZ1v4diDDHsug4QuIj2w== ARC-Seal: a=rsa-sha256; cv=none; d=hornetsecurity.com; i=1; s=hse1; t=1764676111; b=F7AaNN6kHbFYlI1zGQxwPSLGsgbDhikwJHz7UUrZQ/Ka2aHq+4nGs/GDXTnW2CQxg2kLnm3B WDFLmDkNAb4/X4DYx8+XE0fjriQYeGLFJ3RHyYgTF0zPF7AjMI9rIzWfWUSIsBkt+UFsMmcpLm4 kzFSbDDdXIyhk2Ip5XVRGjbg+c6lpE92WyZIjTHQAs1cqu5JToOEX9ozwK1RAhxLFcpju3pFzEc X9p0OszofmxGdpwkfcVAfKBlVOcwNNXVaWlciAOK6gO6QUOWsTn3KPD8a9YEKp7xe1++7XNi22v sStJ8xZKbP5aqhhZSKg0ko4OpkFpiAzNFnp/XhF7452eA== Received: from he-nlb01-hz1.hornetsecurity.com ([94.100.132.6]) by mx-relay90-hz2.antispameurope.com; Tue, 02 Dec 2025 12:48:31 +0100 Received: from steina-w.localnet (host-82-135-125-110.customer.m-online.net [82.135.125.110]) (Authenticated sender: alexander.stein@ew.tq-group.com) by smtp-out01-hz1.hornetsecurity.com (Postfix) with ESMTPSA id BAAF7A4128F; Tue, 2 Dec 2025 12:48:15 +0100 (CET) From: Alexander Stein To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, frank.li@nxp.com, Sherry Sun Cc: devicetree@vger.kernel.org, kernel@pengutronix.de, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: dts: imx8qm-ss-dma: correct the dma channels of lpuart Date: Tue, 02 Dec 2025 12:48:15 +0100 Message-ID: <2395053.ElGaqSPkdT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20251202111638.3553-1-sherry.sun@nxp.com> References: <20251202111638.3553-1-sherry.sun@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-cloud-security-sender:alexander.stein@ew.tq-group.com X-cloud-security-recipient:linux-kernel@vger.kernel.org X-cloud-security-crypt: load encryption module X-cloud-security-Mailarchiv: E-Mail archived for: alexander.stein@ew.tq-group.com X-cloud-security-Mailarchivtype:outbound X-cloud-security-Virusscan:CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay90-hz2.antispameurope.com with 4dLJtm3MJzzWycw X-cloud-security-connect: he-nlb01-hz1.hornetsecurity.com[94.100.132.6], TLS=1, IP=94.100.132.6 X-cloud-security-Digest:199991314bca0e7504113f70cfa02bc4 X-cloud-security:scantime:1.766 DKIM-Signature: a=rsa-sha256; bh=cPzBCQ/cVroc4yKwXafobMdff4xUZ/bh1Bgq00vprqk=; c=relaxed/relaxed; d=ew.tq-group.com; h=content-type:mime-version:subject:from:to:message-id:date; s=hse1; t=1764676110; v=1; b=RQ/9kv7+xRRVHfGwAyu4oRhv/1UOYAl6OHTGKravT5f4VKlx87QOvSX+Hu49vVvysSmypbV5 N4qDHqyQI9OjGiXqdruh9Iz36KconnzJOqZJw3e2vQu73lZ80qZCYnMGyKL9D14Y0WiK9GRiuHL LW5BzPGS9UwliGGrJQp21PRxWlWp/l+uWGgoTt2j5ozmZN6aZYI5OK2c7VQb9sN9mT5NCeG9RN3 kSWP7jBPo2vPQMrdQyyYRuOICH+gpGxTxpshPe53CCIJBi1rg+RURy8AcSH0NPi0pCAeUWUF6TM KK3GZigkVlGt8Urud2QKwvfX57eb3WOSZCrVPwjEr4uMA== Hi, Am Dienstag, 2. Dezember 2025, 12:16:38 CET schrieb Sherry Sun: > The commit 616effc0272b5 ("arm64: dts: imx8: Fix lpuart DMA channel > order") swap uart rx and tx channel at common imx8-ss-dma.dtsi. But miss > update imx8qm-ss-dma.dtsi. >=20 > The commit 5a8e9b022e569 ("arm64: dts: imx8qm-ss-dma: Pass lpuart > dma-names") just simple add dma-names as binding doc requirement. >=20 > Correct lpuart0 - lpuart3 dma rx and tx channels, and use defines for > the FSL_EDMA_RX flag. >=20 > Fixes: 616effc0272b5 ("arm64: dts: imx8: Fix lpuart DMA channel order") I'm wondering if this is actually a fix for 5a8e9b022e569 ("arm64: dts: imx8qm-ss-dma: Pass lpuart dma-names") instead. 616effc0272b5 just focuses on the common parts. But I don't have a strong opinion here. Thanks and best regards, Alexander > Signed-off-by: Sherry Sun > --- > arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi b/arch/arm6= 4/boot/dts/freescale/imx8qm-ss-dma.dtsi > index 5f24850bf322..974e193f8dcb 100644 > --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi > @@ -172,25 +172,25 @@ &flexcan3 { > =20 > &lpuart0 { > compatible =3D "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart"; > - dmas =3D <&edma2 13 0 0>, <&edma2 12 0 1>; > + dmas =3D <&edma2 12 0 FSL_EDMA_RX>, <&edma2 13 0 0>; > dma-names =3D "rx","tx"; > }; > =20 > &lpuart1 { > compatible =3D "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart"; > - dmas =3D <&edma2 15 0 0>, <&edma2 14 0 1>; > + dmas =3D <&edma2 14 0 FSL_EDMA_RX>, <&edma2 15 0 0>; > dma-names =3D "rx","tx"; > }; > =20 > &lpuart2 { > compatible =3D "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart"; > - dmas =3D <&edma2 17 0 0>, <&edma2 16 0 1>; > + dmas =3D <&edma2 16 0 FSL_EDMA_RX>, <&edma2 17 0 0>; > dma-names =3D "rx","tx"; > }; > =20 > &lpuart3 { > compatible =3D "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart"; > - dmas =3D <&edma2 19 0 0>, <&edma2 18 0 1>; > + dmas =3D <&edma2 18 0 FSL_EDMA_RX>, <&edma2 19 0 0>; > dma-names =3D "rx","tx"; > }; > =20 >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/