public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sonny Rao <sonnyrao@chromium.org>,
	acme@redhat.com, anton@samba.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFCv3] perf: robustify proc and debugfs file recording
Date: Fri, 15 Jul 2011 07:38:36 +1000	[thread overview]
Message-ID: <23957.1310679516@neuling.org> (raw)
In-Reply-To: <1310647558.27864.19.camel@gandalf.stny.rr.com>

In message <1310647558.27864.19.camel@gandalf.stny.rr.com> you wrote:
> On Thu, 2011-07-14 at 13:34 +1000, Michael Neuling wrote:
> > In message <1310612277.27864.5.camel@gandalf.stny.rr.com> you wrote:
> > > On Wed, 2011-07-13 at 17:40 -0700, Sonny Rao wrote:
> > > > While attempting to create a timechart of boot up I found
> > > > perf didn't tolerate modules being loaded/unloaded.  This patch
> > > > fixes this by reading the file once and then writing the size
> > > > read at the correct point in the file.  It also simplifies the
> > > > code somewhat.
> > > > 
> > > 
> > > I get this:
> > > 
> > > cc1: warnings being treated as errors
> > > util/trace-event-info.c: In function ‘read_header_files’:
> > > util/trace-event-info.c:221: error: unused variable ‘size’
> > > util/trace-event-info.c: In function ‘copy_event_system’:
> > > util/trace-event-info.c:255: error: unused variable ‘size’
> > > make: *** [/tmp/build/util/trace-event-info.o] Error 1
> > 
> > Looks like sonny didn't pick up my changes correctly.  Here's the
> > working I tested with the sizep and warnings cleanups.
> 
> Hmm, your patch has some serious issues caused by your mail client. When
> saving (or looking at the raw message) I get this:

Crap, sorry.  

This is the same mail client I've used for sending patches for donkeys
years so something much have under the covers with a distro upgrade or
some such.  

Mikey

  parent reply	other threads:[~2011-07-14 21:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-12 21:15 [PATCH] [RFC] perf: robustify proc and debugfs file recording Sonny Rao
2011-07-12 21:19 ` Sonny Rao
2011-07-12 22:56 ` Steven Rostedt
2011-07-12 23:01   ` Sonny Rao
2011-07-12 23:29     ` Steven Rostedt
2011-07-13 10:39 ` Michael Neuling
2011-07-13 10:52   ` Michael Neuling
2011-07-13 17:45     ` Sonny Rao
2011-07-13 20:38     ` Steven Rostedt
2011-07-13 20:49       ` Sonny Rao
2011-07-13 20:58         ` Sonny Rao
2011-07-14  0:18           ` Michael Neuling
2011-07-14  0:40             ` [PATCH] [RFCv2] " Sonny Rao
2011-07-14  2:57               ` Steven Rostedt
2011-07-14  3:34                 ` [PATCH] [RFCv3] " Michael Neuling
2011-07-14 12:45                   ` Steven Rostedt
2011-07-14 12:55                     ` Peter Zijlstra
2011-07-14 13:24                       ` Steven Rostedt
2011-07-14 21:38                     ` Michael Neuling [this message]
2011-07-14 21:54                       ` Steven Rostedt
2011-07-14 22:03                         ` Sonny Rao
2011-07-21  9:59                   ` [tip:perf/core] perf: Robustify " tip-bot for Sonny Rao
2011-07-13 16:50 ` [RFC] perf: robustify " Riccardo Magliocchetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23957.1310679516@neuling.org \
    --to=mikey@neuling.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=acme@redhat.com \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    --cc=sonnyrao@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox