Re: [PATCH 1/3] Keys: Pass session keyring to call_usermodehelper()

Andrew Morton
2005-03-23T22:37:02Z

David Howells <dhowells@redhat.com> wrote:
>
>
> Andrew Morton <akpm@osdl.org> wrote:
>
> > > The attached patch makes it possible to pass a session keyring through to
> > > the process spawned by call_usermodehelper().
> >
> > hm. Seems likely to attract angry emails due to breakage of out-of-tree
> > stuff. Did you consider
> >
> > static inline int
> > call_usermodehelper(char *path, char **argv, char **envp, int wait)
> > {
> > return call_usermodehelper_keys(path, argv, envp, NULL, wait);
> > }
>
> No. I can do that if you want. It seems a bit excessive though.
>

Well one question is "does it make sense to make a keyring session a part
of the call_usermodehelper() API?". As it appears that only one caller
will ever want to do that then I'd say no, and that it should be some
specialised thing private to the key code and the call_usermodehelper()
implementation.

So unless you think that a significant number of callers will appear who
are actually using the new capability then it would be better to keep the
existing call_usermodehelper() API.