public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: "Liang, Kan" <kan.liang@linux.intel.com>,
	jolsa@kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org
Cc: ak@linux.intel.com
Subject: Re: [PATCH] perf vendor events intel: Add uncore_upi JSON support
Date: Mon, 13 May 2019 19:05:12 -0300	[thread overview]
Message-ID: <23EB4484-49C2-47CE-BE31-1E83DBA29B87@kernel.org> (raw)
In-Reply-To: <9e816fed-5d00-c490-21b3-ad9c56dac446@linux.intel.com>

On May 13, 2019 6:29:30 PM GMT-03:00, "Liang, Kan" <kan.liang@linux.intel.com> wrote:
>Hi Arnaldo,
>
>Could you please apply this fix?

I think I merged this today, will check.

Thanks

- Arnaldo
>
>Thanks,
>Kan
>
>On 5/7/2019 9:16 AM, kan.liang@linux.intel.com wrote:
>> From: Kan Liang <kan.liang@linux.intel.com>
>> 
>> Perf cannot parse UPI events.
>> 
>>      #perf stat -e UPI_DATA_BANDWIDTH_TX
>>      event syntax error: 'UPI_DATA_BANDWIDTH_TX'
>>                       \___ parser error
>>      Run 'perf list' for a list of valid events
>> 
>> The JSON lists call the box UPI LL, while perf calls it upi.
>> Add conversion support to json to convert the unit properly.
>> 
>> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
>> ---
>>   tools/perf/pmu-events/jevents.c | 1 +
>>   1 file changed, 1 insertion(+)
>> 
>> diff --git a/tools/perf/pmu-events/jevents.c
>b/tools/perf/pmu-events/jevents.c
>> index 68c92bb..daaea50 100644
>> --- a/tools/perf/pmu-events/jevents.c
>> +++ b/tools/perf/pmu-events/jevents.c
>> @@ -235,6 +235,7 @@ static struct map {
>>   	{ "iMPH-U", "uncore_arb" },
>>   	{ "CPU-M-CF", "cpum_cf" },
>>   	{ "CPU-M-SF", "cpum_sf" },
>> +	{ "UPI LL", "uncore_upi" },
>>   	{}
>>   };
>>   
>> 


  reply	other threads:[~2019-05-13 22:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 13:16 [PATCH] perf vendor events intel: Add uncore_upi JSON support kan.liang
2019-05-13 21:29 ` Liang, Kan
2019-05-13 22:05   ` Arnaldo Carvalho de Melo [this message]
2019-05-14 12:59   ` Arnaldo Carvalho de Melo
2019-05-14 14:42     ` Liang, Kan
2019-05-18  8:58 ` [tip:perf/core] " tip-bot for Kan Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23EB4484-49C2-47CE-BE31-1E83DBA29B87@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox