public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	"Maciej Wieczor-Retman" <maciej.wieczor-retman@intel.com>,
	Peter Newman <peternewman@google.com>,
	James Morse <james.morse@arm.com>,
	Babu Moger <babu.moger@amd.com>,
	Drew Fustini <dfustini@baylibre.com>,
	Dave Martin <Dave.Martin@arm.com>
Cc: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
	<patches@lists.linux.dev>
Subject: Re: [PATCH v21 16/18] x86/resctrl: Enable shared RMID mode on Sub-NUMA Cluster (SNC) systems
Date: Tue, 25 Jun 2024 16:35:17 -0700	[thread overview]
Message-ID: <23d982d2-97c5-4f2f-a034-858bec34bef7@intel.com> (raw)
In-Reply-To: <20240621223859.43471-17-tony.luck@intel.com>

Hi Tony,

On 6/21/24 3:38 PM, Tony Luck wrote:
> Hardware has two RMID configuration options for SNC systems. The default
> mode divides RMID counters between SNC nodes. E.g. with 200 RMIDs and
> two SNC nodes per L3 cache RMIDs 0..99 are used on node 0, and 100..199
> on node 1. This isn't compatible with Linux resctrl usage. On this
> example system a process using RMID 5 would only update monitor counters
> while running on SNC node 0.
> 
> The other mode is "RMID Sharing Mode". This is enabled by clearing bit
> 0 of the RMID_SNC_CONFIG (0xCA0) model specific register. In this mode
> the number of logical RMIDs is the number of physical RMIDs (from CPUID
> leaf 0xF) divided by the number of SNC nodes per L3 cache instance. A
> process can use the same RMID across different SNC nodes.
> 
> See the "Intel Resource Director Technology Architecture Specification"
> for additional details.
> 
> When SNC is enabled, update the MSR when a monitor domain is marked
> online. Technically this is overkill. It only needs to be done once
> per L3 cache instance rather than per SNC domain. But there is no harm
> in doing it more than once, and this is not in a critical path.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette

  reply	other threads:[~2024-06-25 23:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21 22:38 [PATCH v21 00/18] Add support for Sub-NUMA cluster (SNC) systems Tony Luck
2024-06-21 22:38 ` [PATCH v21 01/18] x86/resctrl: Prepare for new domain scope Tony Luck
2024-06-21 22:38 ` [PATCH v21 02/18] x86/resctrl: Prepare to split rdt_domain structure Tony Luck
2024-06-21 22:38 ` [PATCH v21 03/18] x86/resctrl: Prepare for different scope for control/monitor operations Tony Luck
2024-06-21 22:38 ` [PATCH v21 04/18] x86/resctrl: Split the rdt_domain and rdt_hw_domain structures Tony Luck
2024-06-21 22:38 ` [PATCH v21 05/18] x86/resctrl: Add node-scope to the options for feature scope Tony Luck
2024-06-21 22:38 ` [PATCH v21 06/18] x86/resctrl: Introduce snc_nodes_per_l3_cache Tony Luck
2024-06-21 22:38 ` [PATCH v21 07/18] x86/resctrl: Block use of mba_MBps mount option on Sub-NUMA Cluster (SNC) systems Tony Luck
2024-06-25 23:28   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 08/18] x86/resctrl: Prepare for new Sub-NUMA Cluster (SNC) monitor files Tony Luck
2024-06-25 23:28   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 09/18] x86/resctrl: Add a new field to struct rmid_read for summation of domains Tony Luck
2024-06-25 23:29   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 10/18] x86/resctrl: Refactor mkdir_mondata_subdir() with a helper function Tony Luck
2024-06-21 22:38 ` [PATCH v21 11/18] x86/resctrl: Allocate a new field in union mon_data_bits Tony Luck
2024-06-25 23:29   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 12/18] x86/resctrl: Create Sub-NUMA Cluster (SNC) monitor files Tony Luck
2024-06-25 23:30   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 13/18] x86/resctrl: Handle removing directories in Sub-NUMA Cluster (SNC) mode Tony Luck
2024-06-25 23:31   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 14/18] x86/resctrl: Fill out rmid_read structure for smp_call*() to read a counter Tony Luck
2024-06-25 23:33   ` Reinette Chatre
2024-06-26 19:35     ` Tony Luck
2024-06-26 21:23       ` Reinette Chatre
2024-06-27 17:31         ` Luck, Tony
2024-06-27 17:52           ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 15/18] x86/resctrl: Make __mon_event_count() handle sum domains Tony Luck
2024-06-25 23:35   ` Reinette Chatre
2024-06-21 22:38 ` [PATCH v21 16/18] x86/resctrl: Enable shared RMID mode on Sub-NUMA Cluster (SNC) systems Tony Luck
2024-06-25 23:35   ` Reinette Chatre [this message]
2024-06-21 22:38 ` [PATCH v21 17/18] x86/resctrl: Sub-NUMA Cluster (SNC) detection Tony Luck
2024-06-21 22:38 ` [PATCH v21 18/18] x86/resctrl: Update documentation with Sub-NUMA cluster changes Tony Luck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23d982d2-97c5-4f2f-a034-858bec34bef7@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=dfustini@baylibre.com \
    --cc=fenghua.yu@intel.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=patches@lists.linux.dev \
    --cc=peternewman@google.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox