From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5D8C4167B for ; Mon, 11 Dec 2023 17:05:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344272AbjLKREx (ORCPT ); Mon, 11 Dec 2023 12:04:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbjLKREv (ORCPT ); Mon, 11 Dec 2023 12:04:51 -0500 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [IPv6:2a00:1098:ed:100::25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66AB68E; Mon, 11 Dec 2023 09:04:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702314295; bh=ql7mK0NO5lV8Eo4S5IGxxve3zvILVNJcv/sz+C+oCKQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YTQiDMPN/cXiD4oPlBzvOVlb047A4bLmZSA4Beb9u0DBldFbh5tmIUYjJcU6W+9fD fPgFrYcpYbA4mP3XTuGxFZzzY6l0RGxbXPdHF5bSGIDK5u6xlF0WJ78BnZD+Qbs2lW CaFRe6wNqjQB8lv6FXwsgJhhE5jwEudiqwL7ExIViJNRMZLqAYNEwgK5oWoadQWcfp Hmqno/NU4eYb8foJJbeN3NbGThZtF3sWrKOh8hxyTlmHA3JtyZstnvOBAiSEO5fV1y frzqjcaLZDO/AUQ6NK4yYRra2Uoo9sxL4he0cBCZkZeW0I3zFZ9R0iftavby7UG7Su NtDCclQRkFxbw== Received: from [100.115.223.179] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 7C081378131A; Mon, 11 Dec 2023 17:04:54 +0000 (UTC) Message-ID: <23ddcf66-7656-466f-9244-f82ffa66e504@collabora.com> Date: Mon, 11 Dec 2023 19:04:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] Improve AMD ACP Vangogh audio support for Steam Deck OLED Content-Language: en-US To: Emil Velikov Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Venkata Prasad Potturu , Marian Postevca , Vijendar Mukunda , Syed Saba Kareem , Alper Nebi Yasak , Kuninori Morimoto , Rander Wang , Pierre-Louis Bossart , Daniel Baluta , Ajit Kumar Pandey , Bard Liao , Kai Vehmanen , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20231209203229.878730-1-cristian.ciocaltea@collabora.com> From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/23 17:12, Emil Velikov wrote: > On 2023/12/09, Cristian Ciocaltea wrote: >> This patch series provides several fixes and improvements to AMD ACP drivers >> targeting the Vangogh platform, as found on the Valve's new Steam Deck OLED. >> >> Although in theory the board should have been supported by both SOF and legacy >> ACP drivers, as of next-20231208 the audio seems to be completely broken. >> >> Please note this only restores the legacy support, while SOF will be handled in >> a separate series. >> >> Cristian Ciocaltea (5): >> ASoC: amd: vangogh: Drop conflicting ACPI-based probing >> ASoC: amd: vangogh: Allow probing ACP PCI when SOF is disabled >> ASoC: amd: vangogh: Switch to {RUNTIME,SYSTEM_SLEEP}_PM_OPS >> ASoC: amd: acp-config: Add missing MODULE_DESCRIPTION >> ASoC: amd: acp: Add missing MODULE_DESCRIPTION in mach-common >> > > If it were me, I'd drop the Fixes tag in the latter two patches since > the warning is harmless and as-is it'll get into the -stable > maintainers' list, who are already pretty swamped with patches. Sure, I can drop them if there is a need for v2. > Regardless, for the series: > Reviewed-by: Emil Velikov Thanks for the review, Cristian > HTH > Emil