From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012008.outbound.protection.outlook.com [40.107.209.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6746239A070 for ; Mon, 10 Aug 2026 06:50:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.8 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786344639; cv=fail; b=NnOKP0J9gpZBDMMqHp10Is/CAs97HI6ooQFJoAO2b1h42ItpfW0uZg+3yw9hb9NPi8HdcAEFSqOI1ducw9uULvY90sUIxowSy05YXS8EIAy051zGOS73+EKM31is6zgCkMp9tefWGoSxf1U+6PIMADeyGGRwwPAqd4Kv8SxV0NE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786344639; c=relaxed/simple; bh=jkoMHZqY5ULGRr5BxTR86DNlxGVIH69Ykrbsh+gI9xc=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=t2usN5UO+q40T2c80DW6CeKt84HvSmg8Dwi0KJb0R8AC65nZKS/0sTakxIVyv8ys3woMBF21YpNm3Ne+vubJ8Xl0xTousqK5Z/A1ULc7qSpB4fkQ2TDfjNTtdbkKQRvInG/L0noXVuaHPV7Z2wht/kebeg7MWJjWzQdQ4z8Bb5g= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Sy/x6McM; arc=fail smtp.client-ip=40.107.209.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Sy/x6McM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sMkrEShOGSvuPDMFVsLR/xE596PMD9rXYenKXNZ7wbiGY5N+/pqkvhSeUTr3bbPpcdVH3+dbR2hLpv62V1bdARPU4bCRgCsXWV7evXE1vtqqDwT5GE9Iv7Zdt5Um9LL5ctkfV8245h+YwqsU/AXumtbBUJvITEk3ORPbPe4FsmE3hC2mnQh9lVF0yEC1vUng3RdhnkVCrzbAkUV0SfM79U3U05hHah6MpISxHRF7cd9U3Ln4+qaVi+4MlLUA0fJxHNOKeOtuLAEMo7QVYWf2HIH9c1JAZV1nGn5RPB8wDOkJT2EZEzRNLMITUU6FTKyH7Gi3REaBloHk1yUex5hwIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8gD6eMPZapcHDA80oq53v6x9zbCYiuhZDWiFcaNIzDU=; b=rxqhRtqjXsJmnVPac9I8UO7dxSmVPjs6CdfXkffqUARu6GoPoxFnwCa5ctgbtxT3dlieAoTD98HruVAIDfqvKsl15FZiY+yZOzrPJOHrWkf7ZxZDf6Q23MQbspzX5hy+vOC+e1uFuR8fkJmmIvD13/QYRWE7AJkhCHp0qaXFR10oQToAs2ZsuM3aO1Qs0JqIh9W2KQarwLi63QLAzxeSj9abDp3Av1bBk+a0JhPgbdU8VRBvWWiZ317gAuOCPOE0Ao75APVZco4ORIBANr5bLaf+7cvbRR2o1GYs5zoEjz8wDwj5tMXFw9JOXgzpHaplKb7bITUAhqCIjPgAt8LZrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=atomlin.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8gD6eMPZapcHDA80oq53v6x9zbCYiuhZDWiFcaNIzDU=; b=Sy/x6McMvArgUflf0x6V6ZM98XC6QUrYm3LXLQ66yoQcS45XiZJ90bF8Y5ovz8IXdQgWVuIiko+KKk/7E21+lYVaOQVseefm+m0IP3MBFX4zPcAfYZ+GjjfaLtQqbZr7wLCRClntOZZcC9q/t3Oxhi6JgJNunRCT9hn+Qh5woNg= Received: from CH0PR13CA0011.namprd13.prod.outlook.com (2603:10b6:610:b1::16) by DS4PR12MB9658.namprd12.prod.outlook.com (2603:10b6:8:280::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 06:50:33 +0000 Received: from CH1PEPF0000AD82.namprd04.prod.outlook.com (2603:10b6:610:b1:cafe::9a) by CH0PR13CA0011.outlook.office365.com (2603:10b6:610:b1::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.11 via Frontend Transport; Mon, 10 Aug 2026 06:50:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH1PEPF0000AD82.mail.protection.outlook.com (10.167.244.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Mon, 10 Aug 2026 06:50:33 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 10 Aug 2026 01:50:33 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 10 Aug 2026 01:50:33 -0500 Received: from [172.31.184.125] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Mon, 10 Aug 2026 01:50:29 -0500 Message-ID: <23de7d75-cde1-4df2-b5ac-71922102a6ca@amd.com> Date: Mon, 10 Aug 2026 12:20:27 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/5] sched/debug: Protect lockless rq->rd access in print_dl_rq() To: Aaron Tomlin , , , , CC: , , , , , , , , , , , References: <20260810015812.428999-1-atomlin@atomlin.com> <20260810015812.428999-2-atomlin@atomlin.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260810015812.428999-2-atomlin@atomlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD82:EE_|DS4PR12MB9658:EE_ X-MS-Office365-Filtering-Correlation-Id: fb35a010-ec2d-4c4b-c892-08def6abad1f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|82310400026|36860700016|23010399003|22082099003|18002099003|11063799006|56012099006|4143699003|10067099003; X-Microsoft-Antispam-Message-Info: /VFqBal0hmrDAemC9tBljkKGx1i+h+wM8at2Bnhx70OdAt3d1Of4n7mhF+Mv/UyaVCwfG/gRvyh8SgyzGF8DId42wAihX4lDJZRkWxjoxa5NWQt4rKojC8tJt1eMNljCm9s+cpsKqDnRt0GZZgHpjyiPsj2Jm6exr+l83PUS9rCvMD1q+Z36uwekJPf7y6d5sQMlPD5PQXpqudxkRQl5JEVQR2Ma/+xoU+9Jjp/1Colj/trID4dvVEgNzjId+w91Vcsv7WYMszv86Njrko0yt9ktfyKt5IXCTxffuVQYMjfNFz8CIvs+oG492g5lHzp6HEHxcmxI8rGrkOVRDhfNTuPwCMRp3YVtlxQ8ZUCWyeCxEE2X4dRd6Gsi9+eRyNWzbj52tALWMKE+EJYkmXMpahOnF7Bcuy43jMJQHazHb+8n+jO8cJhCW8Acf0HxYMxFs5sJO35bqY8vDER45KY0VFxTA28AtZZSCNkqJJQL+SjdtALtWd0yW9W6DHnMPS917k00Zyg/HFUt69ZlAx6W+2KXWx90ipZAJqW1ILbuOUht3O9WpPCTw4TbWUl0a8dW4nPYe4Gp8InGBoPTR8I/BUV9/a/ja+I94SfGezNN8USid79Glko+1MN9uasR5C6fX41mZS1ZOac4RX/sHoRffqS1oAHRE1GbmfMs9Cet5ODFUMN2GN8H0RFsW3D/sk4SCm/WB0bYXPq23jsHVZG20w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(82310400026)(36860700016)(23010399003)(22082099003)(18002099003)(11063799006)(56012099006)(4143699003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RVUqkLg395si3ZJO/ckq03IuQXnpTplbnHhNJM6zIeM8IPrihPKL/Jm3Wp+2HLYsCMP3eF0dXBcg+gkTr+n7coKK1w6TIKzjZxUPPt0WF4gGUgWVt1UeHbaz7k43QK51Spwogx7XZXc5p9Bwl5PjkOW3HdSwP+sERKBppnoUedxNv7phNzhmK/cNnuYg9n4Bx3x94RWeFzP56yo+Io8nQDadi+xqY1iBjLLxFdAualCHiGfbWxhRSlAbimIqnvvQpepXMJyxSQz1yKtAoXfLDu6qPk9rqQFcD8gWi0vShPmkT9IvvJvpHnJDibpiTGJRWE3cAa993u3jT/FUHXWZj+4B4m2mwyDru5zDZKD+LKpLZEZ/FbqwJ8IUDOQ4lpu6Mgep9FS8+7BGVq0Y+TgeawsdKxjgB3CP63Xm5JP77nAA5CYwZL4PX580+n0Wii7d X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 06:50:33.7034 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fb35a010-ec2d-4c4b-c892-08def6abad1f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD82.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR12MB9658 Hello Aaron, On 8/10/2026 7:28 AM, Aaron Tomlin wrote: > @@ -1089,9 +1090,14 @@ void print_dl_rq(struct seq_file *m, int cpu, struct dl_rq *dl_rq) > SEQ_printf(m, " .%-30s: %lu\n", #x, (unsigned long)(dl_rq->x)) > > PU(dl_nr_running); > - dl_bw = &cpu_rq(cpu)->rd->dl_bw; > - SEQ_printf(m, " .%-30s: %lld\n", "dl_bw->bw", dl_bw->bw); > - SEQ_printf(m, " .%-30s: %lld\n", "dl_bw->total_bw", dl_bw->total_bw); > + rcu_read_lock(); > + rd = READ_ONCE(cpu_rq(cpu)->rd); nit. Why not rcu_dereference_all() here to keep symmetry with the update side that now uses rcu_assign_pointer()? > + if (rd) { I don't think rq->rd can ever be NULL after the scheduler has initialized. > + dl_bw = &rd->dl_bw; > + SEQ_printf(m, " .%-30s: %lld\n", "dl_bw->bw", dl_bw->bw); > + SEQ_printf(m, " .%-30s: %lld\n", "dl_bw->total_bw", dl_bw->total_bw); > + } > + rcu_read_unlock(); > > #undef PU > } -- Thanks and Regards, Prateek