From: Bart Van Assche <bvanassche@acm.org>
To: Elijah Wright <git@elijahs.space>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: mq-deadline: check if elevator is attached to queue in dd_finish_request
Date: Tue, 17 Jun 2025 17:19:22 -0700 [thread overview]
Message-ID: <23f31e20-e58f-44e9-b81f-18811ce5c19c@acm.org> (raw)
In-Reply-To: <b2644203-b1cd-4bc9-9afe-bd0ae0390ae4@elijahs.space>
On 6/17/25 3:52 PM, Elijah Wright wrote:
> I see. would it be possible to detach the elevator from the queue in
> elevator_exit instead?
elevator_switch() is called with the request queue frozen.
q_usage_counter is dropped after the blk_mq_finish_request() call
returned. So what you described in your patch description can't happen.
Bart.
prev parent reply other threads:[~2025-06-18 0:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 20:56 [PATCH] block: mq-deadline: check if elevator is attached to queue in dd_finish_request Elijah Wright
2025-06-17 22:25 ` Bart Van Assche
2025-06-17 22:52 ` Elijah Wright
2025-06-18 0:19 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23f31e20-e58f-44e9-b81f-18811ce5c19c@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=git@elijahs.space \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).