From: David Howells <dhowells@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: dhowells@redhat.com, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@amacapital.net>,
Brian Gerst <brgerst@gmail.com>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] x86/cpufeature: Carve out X86_FEATURE_*
Date: Wed, 03 Feb 2016 14:36:29 +0000 [thread overview]
Message-ID: <24000.1454510189@warthog.procyon.org.uk> (raw)
In-Reply-To: <20160122111918.GA9806@pd.tnic>
Borislav Petkov <bp@alien8.de> wrote:
> In file included from arch/x86/boot/mkcpustr.c:20:0:
> arch/x86/boot/../include/asm/cpufeatures.h:4:35: fatal error: asm/required-features.h: No such file or directory
> compilation terminated.
> make[1]: *** [arch/x86/boot/mkcpustr] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [bzImage] Error 2
> make: *** Waiting for unfinished jobs....
>
> That's when you remove the #ifndef guards.
>
> And I think the commit above does this special dancing to keep
> cpufeature.h a kernel-only header and not make it an uapi one. David, am
> I close?
Yes. CONFIG_ symbols should be considered verboten in UAPI headers and
cpufeature.h is all about using them.
David
next prev parent reply other threads:[~2016-02-03 14:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 18:34 [RFC PATCH 0/5] x86/cpufeature: Cleanups and improvements Borislav Petkov
2016-01-21 18:34 ` [PATCH 1/5] x86/cpufeature: Carve out X86_FEATURE_* Borislav Petkov
2016-01-21 18:57 ` H. Peter Anvin
2016-01-21 19:03 ` Borislav Petkov
2016-01-22 11:19 ` Borislav Petkov
2016-02-03 14:36 ` David Howells [this message]
2016-01-21 18:34 ` [PATCH 2/5] x86/cpufeature: Remove static_cpu_has() Borislav Petkov
2016-01-21 19:04 ` Andy Lutomirski
2016-01-21 19:39 ` Borislav Petkov
2016-01-21 19:41 ` H. Peter Anvin
2016-01-21 19:51 ` Borislav Petkov
2016-01-21 19:05 ` H. Peter Anvin
2016-01-21 18:34 ` [PATCH 3/5] x86/cpufeature: Get rid of the non-asm goto variant Borislav Petkov
2016-01-21 18:59 ` H. Peter Anvin
2016-01-21 18:34 ` [PATCH 4/5] x86/alternatives: Add an auxilary section Borislav Petkov
2016-01-21 19:00 ` H. Peter Anvin
2016-01-21 19:07 ` Borislav Petkov
2016-01-21 19:10 ` H. Peter Anvin
2016-01-21 18:34 ` [PATCH 5/5] x86/alternatives: Discard dynamic check after init Borislav Petkov
2016-01-21 19:03 ` H. Peter Anvin
2016-01-21 21:53 ` [RFC PATCH 0/5] x86/cpufeature: Cleanups and improvements Brian Gerst
2016-01-21 22:20 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24000.1454510189@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox