From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755416AbYIXTEc (ORCPT ); Wed, 24 Sep 2008 15:04:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752742AbYIXTEW (ORCPT ); Wed, 24 Sep 2008 15:04:22 -0400 Received: from mx1.redhat.com ([66.187.233.31]:52076 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754550AbYIXTEU (ORCPT ); Wed, 24 Sep 2008 15:04:20 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1222280971.4425.42.camel@calx> References: <1222280971.4425.42.camel@calx> <20080923053228.GA5825@wotan.suse.de> <20080914073906.GA6184@elte.hu> <20080914004442.4f8e851f.akpm@linux-foundation.org> <20080914080631.GA10720@elte.hu> <20080914221231.GG27080@wotan.suse.de> <20080917131419.e6b7622e.akpm@linux-foundation.org> <20080918111226.GD29968@elte.hu> <48D2ABFD.3040103@goop.org> <1221772310.4779.29.camel@calx> <1221877119.8533.2.camel@nimitz> <13787.1222095249@redhat.com> <22749.1222280305@redhat.com> To: Matt Mackall Cc: dhowells@redhat.com, Nick Piggin , Hugh Dickins , Dave Hansen , Jeremy Fitzhardinge , Ingo Molnar , Andrew Morton , a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org, Dave Hansen Subject: Re: [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex Date: Wed, 24 Sep 2008 19:56:58 +0100 Message-ID: <24051.1222282618@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matt Mackall wrote: > Is there any reason I shouldn't use truncate() in regular shmem.c if I > were to unify the two files? It would be nice to keep tiny-shmem.c, well, tiny for NOMMU systems that can't have swap and can't have virtual memory. Note that regular shmem does not now build on top of ramfs, so you'd have to port the ramfs internals to it. David