From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4056630C618 for ; Fri, 14 Nov 2025 09:25:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763112341; cv=none; b=QflK8vW1+3IgFd6lDe1XO1t5jt9+PCWjqiA6o7UUbei3e2hsyexPHXRyKnG6KHHj9RaSEhlhNsdXTNAV2grbGMHo85HxFien5Km1/SRpwxY0TxUJSKg+Y0ZeP045giy/p06mM90s31Sb0ADrXNr6gNvL5bIkJF9AlkTpuynTwgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763112341; c=relaxed/simple; bh=AJN2QsVxRz/TV+WD3eMF4eAyBt2EDjnXsaRk0ZwmCAI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YALkSo54QoPqj1/JOsTVNK/yOO5PlA0mJpRZ+0Xshapc4ts5iBdWgvbVdq9okVgmlqp9TgYGbpavWRHmVzkWFwj3ewnqQ7s69riO1wU20OC1NBiqlyGTgwUx7uU7aoI2DGkUBA3B8anWbR50PGuzGgxHX3SoiF1DQzxOJSs50JA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s03bsySQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s03bsySQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 354BAC4CEF5; Fri, 14 Nov 2025 09:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763112340; bh=AJN2QsVxRz/TV+WD3eMF4eAyBt2EDjnXsaRk0ZwmCAI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=s03bsySQgTiAmWung3dp0SMdOfELmoPFAkNBYvfYICW4E2AdsUDPeW1N5wv5pYg8s RFHRi+o66lqRWa1za0aVCmOFXMtLuWNwWvZl90XERNjWwweJUEI6sKsbK7znCC+fHa Ei+DCdH6Tt80m+NuRmw47o5gYopA4HzQSQbNxglKFTgUQ0exQ3YnLkFzCAYp0JbKfX NYLfK66+fI4T1o7wppXj6Dxy03xN8oPzvKBj6YsyI4qY+VK8/96v9jQmXoEm3aWJSS nZqNCPFVSyot/quAG1s5qwXXKdWx028AIDBRfrOHHiHh63B30ihI71WDQmVJyc9aKu 0DELz9P/UFDxw== Message-ID: <240b0a40-c0da-4995-b7a8-cc98797dd0a2@kernel.org> Date: Fri, 14 Nov 2025 10:25:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/huge_memory: fix override of entry in remove_migration_pmd To: Balbir Singh , linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org Cc: Andrew Morton , Zi Yan , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Oscar Salvador , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Ralph Campbell , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Matthew Brost , Francois Dugast References: <20251114012153.2634497-1-balbirs@nvidia.com> <20251114012153.2634497-2-balbirs@nvidia.com> <406bad47-1637-4891-b418-31f510382384@nvidia.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <406bad47-1637-4891-b418-31f510382384@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14.11.25 02:24, Balbir Singh wrote: > On 11/14/25 12:21, Balbir Singh wrote: >> Recent changes exposed a BUG in remove_migration_pmd() where the >> migration entry was being overridden when the folio is device private. >> >> Use scope local entry for creating the device private pmde. Make the >> pmde writable if the migration entry is writable by moving the check >> is_migration_write() prior to creating the device private entry. >> >> Cc: Andrew Morton >> Cc: David Hildenbrand >> Cc: Zi Yan >> Cc: Joshua Hahn >> Cc: Rakie Kim >> Cc: Byungchul Park >> Cc: Gregory Price >> Cc: Ying Huang >> Cc: Alistair Popple >> Cc: Oscar Salvador >> Cc: Lorenzo Stoakes >> Cc: Baolin Wang >> Cc: "Liam R. Howlett" >> Cc: Nico Pache >> Cc: Ryan Roberts >> Cc: Dev Jain >> Cc: Barry Song >> Cc: Lyude Paul >> Cc: Danilo Krummrich >> Cc: David Airlie >> Cc: Simona Vetter >> Cc: Ralph Campbell >> Cc: Mika Penttilä >> Cc: Matthew Brost >> Cc: Francois Dugast >> >> Signed-off-by: Balbir Singh >> Reviewed-by: Lorenzo Stoakes >> --- >> mm/huge_memory.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> > > Hi, Andrew > > This patch fixes a bug in mm/rmap: extend rmap and migration support device-private entries > in the thp device-private series. When you resend, best to add under the "--" something like "This fixup should be squashed into the patch "$NAMEOFCOMMIT" in mm/mm-unstable" It is also helpful to call the patch then "fixup: $NAMEOFCOMMIT" So it's immediately clear that this is something to be squashed. -- Cheers David