From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932308AbcHIRwi (ORCPT ); Tue, 9 Aug 2016 13:52:38 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:33194 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932132AbcHIRwe (ORCPT ); Tue, 9 Aug 2016 13:52:34 -0400 From: Kashyap Desai References: <20160806063734.31083-1-yinghai@kernel.org> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQEEWHB+E1fsd+rpEXezIh+2a3ZpKQLQMKgSocWaDPA= Date: Tue, 9 Aug 2016 23:22:12 +0530 Message-ID: <240effe70dbbcd5803e70163aacbe57a@mail.gmail.com> Subject: RE: [PATCH] megaraid_sas: Fix probing cards without io port To: "Martin K. Petersen" , Yinghai Lu Cc: Kashyap Desai , Sumit Saxena , "James E.J. Bottomley" , megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > that does not io port resource allocated from BIOS, and kernel can not > > assign one as io port shortage. > > > > The driver is only looking for MEM, and should not fail. > > > It turns out megasas_init_fw() etc are using bar index as mask. > > index 1 is used as mask 1, so that pci_request_selected_regions() is > > trying to request BAR0 instead of BAR1. > > > Fix all related reference. Review patch and looks good. Thanks Yinghai for submitting patch. Acked-by: Kashyap Desai > > Kashyap? Sumit? > > -- > Martin K. Petersen Oracle Linux Engineering