From: Keith Owens <kaos@ocs.com.au>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
davej@redhat.com, torvalds@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: __init dependencies
Date: Tue, 12 Oct 2004 16:06:02 +1000 [thread overview]
Message-ID: <24112.1097561162@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Mon, 11 Oct 2004 21:04:46 MST." <416B57DE.4070605@osdl.org>
On Mon, 11 Oct 2004 21:04:46 -0700,
"Randy.Dunlap" <rddunlap@osdl.org> wrote:
>Randy.Dunlap wrote:
>> Andrew Morton wrote:
>>
>>> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>>
>>>> I guess it's about time for a tool to autodetect __init dependencies?
>>>
>>> `make buildcheck' does this. Looks like nobody is using it.
>
>John Cherry has been running 'make buildcheck' regularly,
>but apparently nobody has been looking.
>
>Latest (2.6.9-rc4) is here:
>http://developer.osdl.org/cherry/compile/2.6/linux-2.6.9-rc4.results/2.6.9-rc4.reference_init26.bzImage.txt
>
>My experience with output of buildcheck is that it's verbose and has
>lots of false positives. (Yes, I have used it and generated patches
>from it.) First thing I do is delete all lines that match
>"data.*init" or "data.*exit". These are (usually -- famous word) OK.
They may only be OK because the code is never run more than once.
Normal code that refers to data.*init and is run more than once is a
bug just waiting to bite you.
Andrew - small fix for reference_init.pl, against 2.6.9-rc4.
------------------------------------------------------------
Treat .pci_fixup entries the same as .init code/data.
Signed off by: Keith Owens <kaos@ocs.com.au>
Index: linux/scripts/reference_init.pl
===================================================================
--- linux.orig/scripts/reference_init.pl Sat Aug 14 15:37:37 2004
+++ linux/scripts/reference_init.pl Tue Oct 12 15:59:39 2004
@@ -93,6 +93,8 @@ foreach $object (sort(keys(%object))) {
$from !~ /\.stab$/ &&
$from !~ /\.rodata$/ &&
$from !~ /\.text\.lock$/ &&
+ $from !~ /\.pci_fixup_header$/ &&
+ $from !~ /\.pci_fixup_final$/ &&
$from !~ /\.debug_/)) {
printf("Error: %s %s refers to %s\n", $object, $from, $line);
}
next prev parent reply other threads:[~2004-10-12 6:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-10 22:57 [PATCH] find_isa_irq_pin can't be __init Dave Jones
2004-10-11 11:33 ` __init dependencies (was: Re: [PATCH] find_isa_irq_pin can't be )__init Geert Uytterhoeven
2004-10-11 19:12 ` Andrew Morton
2004-10-11 19:16 ` Dave Jones
2004-10-11 19:17 ` __init dependencies Randy.Dunlap
2004-10-12 4:04 ` Randy.Dunlap
2004-10-12 4:19 ` Andrew Morton
2004-10-12 6:06 ` Keith Owens [this message]
2004-10-20 16:08 ` [PATCH] __init dependencies: ignore __param Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24112.1097561162@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox