From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759467AbbFBPlT (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Jun 2015 11:41:19 -0400
Received: from galahad.ideasonboard.com ([185.26.127.97]:48980 "EHLO
	galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759077AbbFBPlL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Jun 2015 11:41:11 -0400
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Colin King <colin.king@canonical.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Felipe Balbi <balbi@ti.com>, Sudeep Holla <sudeep.holla@arm.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null
Date: Tue, 02 Jun 2015 18:41:37 +0300
Message-ID: <2412438.ObMLH8QmsQ@avalon>
User-Agent: KMail/4.14.3 (Linux/3.18.11-gentoo; KDE/4.14.3; x86_64; ; )
In-Reply-To: <556C6362.1010700@cogentembedded.com>
References: <1433112223-4651-1-git-send-email-colin.king@canonical.com> <556C6362.1010700@cogentembedded.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 01 June 2015 16:51:30 Sergei Shtylyov wrote:
> Hello.
> 
> On 6/1/2015 1:43 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > If kzalloc returns null then isp1760_ep_alloc_request performs
> > a null pointer dereference on req. Check for null to avoid this.
> 
> I told you there's no dereference and yet you're repeating it again. :-(

How about

"isp1760_ep_alloc_request allocates a structure with kzalloc without checking 
for NULL and then returns a pointer to one of the structure fields. As the 
field happens to be the first in the structure the caller can properly check 
for NULL, but this is risky if the structure layout is changed later. Add an 
explicit NULL check for the kzalloc return value."

> > a null pointer dereference on req. Check for null to avoid this.
> >
> > Detected with smatch static analysis:
> > 
> > drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request()
> > 
> >    error: potential null dereference 'req'.  (kzalloc returns null)
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>

-- 
Regards,

Laurent Pinchart