Re: [PATCH 04/14] watchdog: sunxi_wdt: Add support for Allwinner A523

["Jernej Škrabec" <jernej.skrabec@gmail.com>]

Dne ponedeljek, 11. november 2024 ob 02:30:23 Srednjeevropski standardni čas je Andre Przywara napisal(a):
> The Allwinner A523 SoC comes with a watchdog very similar to the ones in
> the previous Allwinner SoCs, but oddly enough moves the first half of its
> registers up by one word. Since we have different offsets for these
> registers across the other SoCs as well, this can simply be modelled by
> just stating the new offsets in our per-SoC struct.
> The rest of the IP is the same as in the D1, although the A523 moves its
> watchdog to a separate MMIO frame, so it's not embedded in the timer
> anymore. The driver can be ignorant of this, because the DT will take
> care of this.
> 
> Add a new struct for the A523, specifying the SoC-specific details, and
> tie the new DT compatible string to it.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej