Re: [PATCH] PAG support, try #2

Matthew Wilcox
2003-05-14T11:37:14Z

On Wed, May 14, 2003 at 11:43:31AM +0100, David Howells wrote:
> +typedef int __kernel_pag_t;

> +typedef __kernel_pag_t pag_t;

> +static pag_t vfs_pag_next = 1;

> + vfspag->pag = vfs_pag_next++;
> + if (vfspag->pag < 1)
> + vfspag->pag = 1;

Is there a reason pag_t isn't an unsigned int? Seems to me you'll have
2^31 good times followed by 2^31 bad times. Also, isn't signed overflow
one of these undefined things? I wouldn't mention it except that gcc
seem to be more and more fond of obeying the letter of the standard
rather than doing useful stuff.

--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk