From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751473AbcBKQdO (ORCPT ); Thu, 11 Feb 2016 11:33:14 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:62824 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbcBKQdL (ORCPT ); Thu, 11 Feb 2016 11:33:11 -0500 From: Arnd Bergmann To: Paul Gortmaker Cc: Greg Kroah-Hartman , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby , linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 1/6] Revert "drivers/tty/serial: make 8250/8250_mtk.c explicitly non-modular" Date: Thu, 11 Feb 2016 17:32:17 +0100 Message-ID: <2425581.FEKcoTMtxH@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160211162852.GJ28452@windriver.com> References: <1455205297-1021302-1-git-send-email-arnd@arndb.de> <3873766.I9XIY0R8gT@wuerfel> <20160211162852.GJ28452@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Kh4D4bHs8GwgUXB4yzoZLUk6sGm/lR/y/U14vYx8u/mN8lW9NAV qxztASTNTPrxTcI2tmtTdH8VbS+ESZIYA0aPTpFdJv+Wnu6A2JKXJS3NiU8lDebSM5tonSn 3ZcZ2NqUzQYfbVDGDBvk6YJU/tFBd+hWbSdXoYKymIKafTeuXAY1gdQxA6nzf/KKbxJKwWC 7pstKU43oKY62YazQoB3Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:vUuC4QZ7Q2Q=:ewVYXkNUv/6X7RvprfejD6 PC0v/ZEwdAwDeLZB43/LK1dzwWmHnjk9pGuhuCAHWwQdk2hTLEXpUI8WQGS9PDpaw4HCSuLCt yXTI3W0MyKiTA5XVqj9ksWC9ccRN00rhq1YmrBBv2V+Phsj2/1BN8NBOaxbkg52Hg4T4MUFxG L0RXVQuiE06oKZhBmYsxtoiwSHx4gcJOaX+NV5Al1GD9Ak669d0iIpoim7/l2PUIVOsDuQOxL iupk8bzKVFEvdm5PIMwmvFXe/d++GC0L+WwGTSKfqzgxExyOpMGijR/vwDmlqP3NUXF163S3o OfkyVUFZCD4K93xvHBbWhYzaqbf8eL5lO7hz7aEtbyyRuZ3ZXXUGGLqBkaWatu2sY6IMcanaD UDZ9Y6x6qM3YlxvITOS1X7bbTf0ivGLxaXEOU6MghAVsyqA7k9PoBiFQ0C0d+hCm47sbNWMlH jQip0Qz1IoZY3cXQKeXL66mi2tpQmDXK91RDodS7hiv11WZyVa+FhwO5W1f+cnxdYSWcruGan tn0Uy0xHzKSDXoFFgAu8nBg6jSDIQIOFcm6Gl+k9xjYNk42r6zrTg/1oqxic6oazyY7QBgWcG yMoLBJVNsuxu08hnudtnRjEDh2+C25zl4dKYHAZJZUSVZ4CMud9YwB1pv5qLpiT/qo7YlAWnj eyOuFqPCFGLzC49gZM+pGlyC0Jje9nAO1jLqigzHUK8oAvup5p/1C1b3eiB72MJPaF1K2EJhn QhDoMrTlxaqxE46e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 11 February 2016 11:28:52 Paul Gortmaker wrote: > [Re: [PATCH v2 1/6] Revert "drivers/tty/serial: make 8250/8250_mtk.c explicitly non-modular"] On 11/02/2016 (Thu 17:06) Arnd Bergmann wrote: > > > On Thursday 11 February 2016 11:00:22 Paul Gortmaker wrote: > > > [[PATCH v2 1/6] Revert "drivers/tty/serial: make 8250/8250_mtk.c explicitly non-modular"] On 11/02/2016 (Thu 16:41) Arnd Bergmann wrote: > > > > > > > This reverts commit d72d391c126e, which tried to remove dead code but > > > > left the driver in a useless state when the main 8250 driver is a > > > > > > Am I misunderstanding something? The commit didn't cause the driver to > > > be in a useless state for 8250=m. But rather isn't that it was a > > > pre-existing condition, independent of the change to 8250_mtk.c to > > > remove the dead code in d72d391c126e? > > > > > > Since the commit did not touch Kconfig or Makefile, I can't see how it > > > could cause some new useless state that did not already exist, and hence > > > the "Fixes:" tag is invalid as well. > > > > My wording may have been bad here. What I meant to say is that it > > was broken before the patch, and still broken after the patch. > > OK, no problem. I just didn't want Greg/Jiri to think I was sending them > broken commits. Will need a v3 to get rid of the extra module.h > anyway, so that gives you a chance to reword. Sure. > > > > The Fixes tag was meant to just be a reference to the commit I'm > > reverting. > > Yeah, but since the stable people trigger off of that, and since the > revert doesn't really fix anything, that is probably best removed. > The stable trees don't need the revert. Yes, good point. Arnd