From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: LMML <linux-media@vger.kernel.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] Davinci VPBE use devres and some cleanup
Date: Wed, 17 Jul 2013 14:21:29 +0200 [thread overview]
Message-ID: <2425805.RBpmei1UGe@avalon> (raw)
In-Reply-To: <1373705431-11500-1-git-send-email-prabhakar.csengg@gmail.com>
Hi Prabhakar,
On Saturday 13 July 2013 14:20:26 Prabhakar Lad wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> This patch series replaces existing resource handling in the
> driver with managed device resource.
Thank you for the patches. They greatly simplify the probe/remove functions, I
like that. For patches 1 to 4,
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I have the same concern as Joe Perches for patch 5.
> Lad, Prabhakar (5):
> media: davinci: vpbe_venc: convert to devm_* api
> media: davinci: vpbe_osd: convert to devm_* api
> media: davinci: vpbe_display: convert to devm* api
> media: davinci: vpss: convert to devm* api
> media: davinci: vpbe: Replace printk with dev_*
>
> drivers/media/platform/davinci/vpbe.c | 6 +-
> drivers/media/platform/davinci/vpbe_display.c | 23 ++----
> drivers/media/platform/davinci/vpbe_osd.c | 45 +++---------
> drivers/media/platform/davinci/vpbe_venc.c | 97 ++++-----------------
> drivers/media/platform/davinci/vpss.c | 62 ++++------------
> 5 files changed, 52 insertions(+), 181 deletions(-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-07-17 12:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-13 8:50 [PATCH 0/5] Davinci VPBE use devres and some cleanup Prabhakar Lad
2013-07-13 8:50 ` [PATCH 1/5] media: davinci: vpbe_venc: convert to devm_* api Prabhakar Lad
2013-07-13 8:50 ` [PATCH 2/5] media: davinci: vpbe_osd: " Prabhakar Lad
2013-07-13 8:50 ` [PATCH 3/5] media: davinci: vpbe_display: convert to devm* api Prabhakar Lad
2013-07-13 8:50 ` [PATCH 4/5] media: davinci: vpss: " Prabhakar Lad
2013-07-13 8:50 ` [PATCH 5/5] media: davinci: vpbe: Replace printk with dev_* Prabhakar Lad
2013-07-13 13:07 ` Joe Perches
2013-07-17 12:21 ` Laurent Pinchart [this message]
2013-07-17 16:30 ` [PATCH 0/5] Davinci VPBE use devres and some cleanup Prabhakar Lad
2013-07-23 11:17 ` Prabhakar Lad
2013-07-23 11:44 ` Abraham, Tobin
2013-07-23 11:50 ` Prabhakar Lad
2013-07-23 11:49 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2425805.RBpmei1UGe@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).