From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761618AbYEMVXQ (ORCPT ); Tue, 13 May 2008 17:23:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757513AbYEMVW5 (ORCPT ); Tue, 13 May 2008 17:22:57 -0400 Received: from agminet01.oracle.com ([141.146.126.228]:44876 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752429AbYEMVW4 (ORCPT ); Tue, 13 May 2008 17:22:56 -0400 Message-ID: <24291087.1210713535895.JavaMail.oracle@acsmt301.oracle.com> Date: Tue, 13 May 2008 16:18:55 -0500 (CDT) From: Randy Dunlap To: "Eric W. Biederman" , Greg KH Subject: Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v3 Cc: Al Viro , Benjamin Thery , Greg KH , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Daniel Lezcano , Andrew Morton , Pavel Emelyanov , "Serge E. Hallyn" , Tejun Heo In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit References: <20080512220232.GA16914@kroah.com> <4829A4BD.3020007@bull.net> <20080513164438.GA31563@kroah.com> <20080513201602.GA31578@kroah.com> X-Priority: 3 X-Mailer: Oracle Webmail Client(UIX) Content-Language: en-US Accept-Language: en-US X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Changelog: > v3: Documentation typo fixes Inserted/attached wrong patch file? I don't see any text changes. > diff --git a/Documentation/kobject.txt b/Documentation/kobject.txt > index bf3256e..79184b4 100644 > --- a/Documentation/kobject.txt > +++ b/Documentation/kobject.txt > @@ -118,6 +118,10 @@ the name of the kobject, call kobject_rename(): > > int kobject_rename(struct kobject *kobj, const char > *new_name); > > +Note kobject_rename does perform any locking or have a solid > notion of > +what names are valid so the provide must provide their own > sanity checking > +and serialization. > + > There is a function called kobject_set_name() but that is > legacy cruft and > is being removed. If your code needs to call this function, > it is > incorrect and needs to be fixed.