Re: [PATCH -next] edac/mce_amd: fix shift warning

[Doug Thompson <norsk5@yahoo.com>]

--- On Wed, 10/13/10, Randy Dunlap <randy.dunlap@oracle.com> wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> Subject: [PATCH -next] edac/mce_amd: fix shift warning
> To: "lkml" <linux-kernel@vger.kernel.org>
> Cc: "Doug Thompson" <dougthompson@xmission.com>, "Borislav Petkov" <borislav.petkov@amd.com>, "akpm" <akpm@linux-foundation.org>
> Date: Wednesday, October 13, 2010, 2:10 PM
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> The BIT() macro works on unsigned longs, but this warning
> happens
> on i386 (X86_32), where UL is 32 bits and this value needs
> to be
> 64 bits, so use open-coded ULL.

good find


> 
> drivers/edac/mce_amd.c:262: warning: left shift count >=
> width of type
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Signed-off-by: Doug Thompson <dougthompson@xmission.com>


> Cc: Doug Thompson <dougthompson@xmission.com>
> Cc: Borislav Petkov <borislav.petkov@amd.com>
> ---
>  drivers/edac/mce_amd.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-next-20101012.orig/drivers/edac/mce_amd.c
> +++ linux-next-20101012/drivers/edac/mce_amd.c
> @@ -259,7 +259,8 @@ static void amd_decode_ic_mce(struct
> mce
>          pr_cont("%s TLB
> %s.\n", LL_MSG(ec),
>             
> (xec ? "multimatch" : "parity error"));
>      else if (BUS_ERROR(ec)) {
> -        bool k8 =
> (boot_cpu_data.x86 == 0xf && (m->status &
> BIT(58)));
> +        bool k8 =
> (boot_cpu_data.x86 == 0xf &&
> +           
>     (m->status & (1ULL <<
> 58)));
>  
>          pr_cont("during
> %s.\n", (k8 ? "system linefill" : "NB data read"));
>      } else if (fam_ops->ic_mce(ec))
>