From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 061DC314B96 for ; Sun, 12 Jul 2026 19:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783883279; cv=none; b=PwD5e/mYUaF1E0oZOpC8PB3REUCze+hwgv0M7YhHfDC8Z6R1KWYs8XwNBGRNUcn6OJwxXIcyAUudjyQ5z0hr00XRfKzrza4XDqUv0kvCf8BhOq5ATQf6/u9dUomg4BnfPew5e+wB2c/GeB6cT+eLFFoRGKTyaACsZ2/9f58iL7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783883279; c=relaxed/simple; bh=Zq5rj8MXuH9eq+y9VKSH0dwCH55KqEZTdD7vc4Szt+g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ViRCimtsXKg4szqTqGjV+v5betoaBbBqe8O+9IB0Y2di3hA9udQ35+NhBS9bI16FjtCvWqCK9jYf1fvu+upJgUlce0OiHJBi2eAEjzVM08mqJx7wVZQ30vxiOok978TIo8IOyY0GlvbvRU9v1b8weqN0tvLpKQf9agSXZ41FLDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SKABp/HF; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SKABp/HF" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-476a130c138so3001294f8f.0 for ; Sun, 12 Jul 2026 12:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783883276; x=1784488076; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+xZg60sAAA06cSnVFm1g3I8u9K5C+cZsTy9v614jrUA=; b=SKABp/HF3BtuQPaou5DG8ZCZ0FdaI+GKp0HHZ/WkT6Ac42pquyYQ5Ek69FjjNe4AHV NtFCBCbjbXn6gNv86deIl3qBRVu3r+wNN0J8o3RQQAArNeOHFXJu3ySx2CdYcszwnElu rOPrtbrbthKssi+9y6A7BmJoM1HBGz6f4a+mmM+oBQ0fvRD9rpNyYv6CzsBGfSW15wov 0181jdIyXP49KiFlk1wtq+gDBv53kx3OAJIqwkJrQoZk0S7f0caJPkxCfo6HJnMNHcSa vJPpOLuEBsErvVXv9cmtsiZsXOaK4vIilidPD3xY3Y78Z3uxQt6/Zc0JAfkcDuUuzf7B zQRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783883276; x=1784488076; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+xZg60sAAA06cSnVFm1g3I8u9K5C+cZsTy9v614jrUA=; b=YRbn8+9Lpf+hbHYuBZnvfs2UNDR36XiD2AM2Qodq+nouQ0mG3eYMSm7aAqBJRytrsX vRc7KZ4wJszXllOqzrwgUMcOWPESbi1CUJcMj3SQoAFdtNtkcX7vbzDZnELZjPAYYo6A qPytbcaZIRykFMas5TGlZm6RLNXDh1Lz68GGdixCiw1jRf7ETbwDfOIJF807OfQoFaZ3 oC+tXST4nyMHk5DlbGC02Z1mICB9pM4ineyNR+s5XDZFKMZIyaDWfIG1E+dfW2s2YzPv 207i6DdjLTiLKBeBB8i4REXjIzlvkTkbJr3EBQv/MXSStxtOB7JZLJIhBdRLr69CEcFJ yo2g== X-Forwarded-Encrypted: i=1; AHgh+RphEO/7v8IsAQO6pPuj5NBhnckR0WilujtRlsv3BEaGkaXRQ+W0bAJyvWxzJimbAB4t44q4ObFq273Y5IM=@vger.kernel.org X-Gm-Message-State: AOJu0YyWaqbIxDM2TbE5FEUNQ2T4cwt0oQC/hsBt+ekpvdNRfYRpPGH3 cKDp8d4TLZGMrVCZBw3Y17L5E0sIMCwa94y38Ygrslj1CTk+U+5oRJXG X-Gm-Gg: AfdE7cmmY9y5kjy5m9t4wqn5YIEO9HPg61wvNwLjdaOmfvYV1SE+BqfHBMNWh/ahRDx W3pD1QfChKahcAdJniraQRZw6kvesKWY1yt7bylOpi3+IwTJj9ln3pVhlKW2BPP0elakT82wzi+ eGrNxT/6oeVeyEL1FQZAUaJuOTCTUrHWRvrhkZk2DVD8b2BuboDz6cXkeGOgVyUHEKO4xRDSP+0 WGIYPwEFKi0kJf0guRRzPgk22RDyB02ceOrhMgqJHAodwWY+ha86mtT5VzwYsAluTzWewdYfiLy 14Ve3aioyl6FG+YSDv80Odis3ocJWlGKMEg1MVysRyCWFZlXeqzCUFlmp/uYLhGg4KUgip+Icji tTIzyUYq/Msr7ndZjNBpZn1ROA9m82XCZ1HdLigNf+WUImq6y3P3c/eWa7nojNBzNzkBcoendu4 zI+dRuYaEMAUUN99HZhg0+M5RKVE+fU2Qgw2c= X-Received: by 2002:a5d:64eb:0:b0:474:8aad:2f8 with SMTP id ffacd0b85a97d-47f2dd2bd97mr8223971f8f.41.1783883276216; Sun, 12 Jul 2026 12:07:56 -0700 (PDT) Received: from [192.168.1.10] ([95.43.220.235]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-47aa0f213e8sm77422974f8f.34.2026.07.12.12.07.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jul 2026 12:07:55 -0700 (PDT) Message-ID: <24368e1c-171f-4f6b-80f8-58accab1d3be@gmail.com> Date: Sun, 12 Jul 2026 22:07:53 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] drm/omap: dsi: avoid sending bta sync all the time in writes To: Andreas Kemnade Cc: Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sebastian Reichel , Laurent Pinchart , Tony Lindgren , Linux-OMAP , Marek Vasut , "H. Nikolaus Schaller" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomi Valkeinen References: <20260629-vm-upstr-v4-1-9f0c62d8808e@kemnade.info> <4cb964d9-524d-40ec-8cd2-d936fff8eb85@gmail.com> <20260707122203.0bbc973e@kemnade.info> Content-Language: en-GB From: Ivaylo Dimitrov In-Reply-To: <20260707122203.0bbc973e@kemnade.info> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7.07.26 г. 13:22 ч., Andreas Kemnade wrote: > On Tue, 30 Jun 2026 08:42:57 +0300 > Ivaylo Dimitrov wrote: > >> Hi, >> With this version of the patch I see: >> >> [ 102.760894] DSI: omapdss DSI error: Framedone not received for 250ms! >> [ 303.860321] DSI: omapdss DSI error: Framedone not received for 250ms! >> [ 307.071624] DSI: omapdss DSI error: Framedone not received for 250ms! >> [ 307.360626] DSI: omapdss DSI error: Framedone not received for 250ms! >> [ 307.671142] DSI: omapdss DSI error: Framedone not received for 250ms! >> [ 308.660339] DSI: omapdss DSI error: Framedone not received for 250ms! >> [ 308.961059] DSI: omapdss DSI error: Framedone not received for 250ms! >> [ 313.191314] DSI: omapdss DSI error: Framedone not received for 250ms! >> [ 313.700378] DSI: omapdss DSI error: Failed to set dsi_if_enable to 0 >> [ 313.980346] DSI: omapdss DSI error: Framedone not received for 250ms! >> [ 314.791564] DSI: omapdss DSI error: Framedone not received for 250ms! >> [ 315.090362] DSI: omapdss DSI error: Framedone not received for 250ms! >> [ 322.850952] DSI: omapdss DSI error: Framedone not received for 250ms! >> [ 323.111175] DSI: omapdss DSI error: Framedone not received for 250ms! >> >> while scrolling the (hildon)desktop on droid4, so I would say the change >> broke command mode. >> > so let me summarize: > - sending initialisation commands to video mode panel: no problem visible in > any case, theretical problems (not seen with the tested panels if sending too much data, fixed via v4. > - command mode display: no picture and error messages without any bta sync (patch version 1). > - working display with send_nop() replaced by simply sending bta_sync() and not > waiting for PACKET_SENT irq for short packets (v2). > - partly working display (with v4), (always waiting for PACKET_SENT) > > so there are some situations when waiting for a packet completition is harmful. > In your case these were only siutations when short packets were sent. > Do you have a more complete log of v4 boott? > In the log for v1 which is not accessible anymore, there were other > more informative timeouts visible. > > But maybe as a wild guess also based on Sasikhos AI reviews, maybe > this helps: > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 3f22929c36e2..eb3cd0d23cae 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -3267,7 +3267,7 @@ static int dsi_update_channel(struct omap_dss_device *dssdev, int vc) > * updates stop working. This is probably related to DSI spec stating > * that the DSI host should transition to LP at least once per frame. > */ > - r = dsi_vc_send_bta_sync(dssdev, vc); > + r = dsi_vc_send_bta_sync(dssdev, VC_CMD); > if (r < 0) { > DSSWARN("failed to send bta sync between frames: %d\n", r); > goto err; > > > > Then the call is equal to the original one done via send_nnop. > With that change it seems to work properly, will keep that version of the driver for the time being. > Regards, > Andreas