From: David Howells <dhowells@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@osdl.org, torvalds@osdl.org, davidm@snapgear.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] BDI: Provide backing device capability information
Date: Mon, 07 Mar 2005 15:41:21 +0000 [thread overview]
Message-ID: <24382.1110210081@redhat.com> (raw)
In-Reply-To: <E1D8K3T-00056q-00@dorka.pomaz.szeredi.hu>
Miklos Szeredi <miklos@szeredi.hu> wrote:
> > The attached patch replaces backing_dev_info::memory_backed with
> > capabilitied bitmap. The capabilities available include:
>
> Wouldn't it be better to reverse the meaning of BDI_CAP_ACCOUNT_DIRTY
> and BDI_CAP_WRITEBACK_DIRTY (BDI_CAP_NO_ACCOUNT_DIRTY...)? That way
> out of tree filesystems that implicitly zero bdi->memory_backed
> wouldn't _silently_ break. E.g. fuse does this, though it would not
> actually break since it doesn't dirty any pages currently. I have no
> idea whether there are other filesystems that are affected.
It shouldn't silently break... It will refuse to compile. I renamed
"memory_backed" to "capabilities".
David
next prev parent reply other threads:[~2005-03-07 15:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 15:50 Improving mmap() support for !MMU further David Howells
2005-03-02 17:07 ` Andrew Morton
2005-03-02 21:34 ` [PATCH 1/2] BDI: Provide backing device capability information David Howells
2005-03-02 21:51 ` Andrew Morton
2005-03-02 22:28 ` Linus Torvalds
2005-03-02 22:39 ` Andrew Morton
2005-03-03 13:42 ` David Howells
2005-03-03 20:33 ` Andrew Morton
2005-03-03 13:38 ` David Howells
2005-03-03 20:34 ` Andrew Morton
2005-03-07 11:23 ` David Howells
2005-03-07 11:37 ` Andrew Morton
2005-03-07 11:43 ` David Howells
2005-03-07 11:47 ` Andrew Morton
2005-03-07 11:51 ` David Howells
2005-03-07 12:10 ` Andrew Morton
2005-03-07 12:25 ` David Howells
2005-03-07 14:05 ` David Howells
2005-03-07 15:21 ` Miklos Szeredi
2005-03-07 15:41 ` David Howells [this message]
2005-03-07 15:45 ` Miklos Szeredi
2005-03-07 16:06 ` David Howells
2005-03-07 16:15 ` Miklos Szeredi
2005-03-07 20:14 ` Andrew Morton
2005-03-08 14:12 ` [PATCH 1/2] BDI: Provide backing device capability information [try #3] David Howells
2005-03-09 0:37 ` Andrew Morton
2005-03-09 10:27 ` David Howells
2005-03-02 21:41 ` [PATCH 2/2] BDI: Improve nommu mmap support David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24382.1110210081@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=davidm@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox