From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7D6C433E6 for ; Thu, 21 Jan 2021 20:01:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3CA023A58 for ; Thu, 21 Jan 2021 20:01:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726873AbhAUUBq convert rfc822-to-8bit (ORCPT ); Thu, 21 Jan 2021 15:01:46 -0500 Received: from mailoutvs41.siol.net ([185.57.226.232]:52768 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726848AbhAUTzB (ORCPT ); Thu, 21 Jan 2021 14:55:01 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id A146F520BDA; Thu, 21 Jan 2021 20:54:09 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id B90abY8oWMUe; Thu, 21 Jan 2021 20:54:09 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 5D80B5235B6; Thu, 21 Jan 2021 20:54:09 +0100 (CET) Received: from kista.localnet (cpe-86-58-58-53.static.triera.net [86.58.58.53]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id EC71B520BDA; Thu, 21 Jan 2021 20:54:07 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-arm-kernel@lists.infradead.org, Hermann Lauer Cc: mripard@kernel.org, wens@csie.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node Date: Thu, 21 Jan 2021 20:54:07 +0100 Message-ID: <2438641.b0YrFlWa0f@kista> In-Reply-To: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> References: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne četrtek, 21. januar 2021 ob 18:08:36 CET je Hermann Lauer napisal(a): > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high > packet loss rates. The realtek phy driver overrides the settings of the > pull ups for the delays, so fix this for Banana Pro. > > Signed-off-by: Hermann Lauer Much better. Now the only thing missing is "Fixes" tag, which references commit which introduced the issue. Probably this will be the commit which added ethernet node. This tag is important for deciding which commits should be backported to stable releases. Take a look in v1 for M2U fixes tag. Btw, each version should have changelog under "---" line, so maintainers and reviewers know what changed. Best regards, Jernej