From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 073B3C433EF for ; Thu, 7 Jul 2022 10:59:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235155AbiGGK7z (ORCPT ); Thu, 7 Jul 2022 06:59:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230187AbiGGK7v (ORCPT ); Thu, 7 Jul 2022 06:59:51 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDDEC57224; Thu, 7 Jul 2022 03:59:50 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0319466019AF; Thu, 7 Jul 2022 11:59:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657191588; bh=Ncasodb0mlhKue8G5um/dzJDJSNHJ442SPjDYU2q3GI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=G3Wb0DHsH05SDtLOudN/tZyJYo7/p+kDkzNgTgA/qmXdIPemFSZ5Gp8mg7sHTnbo8 EPxxgeujFcYAVjQWRmi3qfj0zHSvYLfSCJC7H6tEaliGTh6w4anzitaB/H/gJ5bKg8 y6mxUghQ6cvnE7Zbp3n7ePsPsO2hydtEIAZvXjCZTbehGd3YfouYSxL2CMjMF8WUsR sVeeDqcJCbu71+gQBISChVWgpY4jm8gwFQ158lXk2y0LfWpX3u9/isgH09jXZ5KUkd LNYC/F0a9UMtAqWxw34Bh3k+NGCc4o611IAAe3qUf2hkIaZgOGItUzdibxR5gvgoB4 joD5hcJd9qoBg== Message-ID: <243b30ca-a552-3cb7-8a4e-6e54a56ff60a@collabora.com> Date: Thu, 7 Jul 2022 12:59:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] dt-bindings: soc: mediatek: add mdp3 mutex support for mt8186 Content-Language: en-US To: Matthias Brugger , Allen-KH Cheng , Rob Herring , Krzysztof Kozlowski , Chun-Kuang Hu , Philipp Zabel Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Xiandong Wang References: <20220705122627.2273-1-allen-kh.cheng@mediatek.com> <20220705122627.2273-2-allen-kh.cheng@mediatek.com> <5916c91b-41a1-c97a-84b4-7d48739a0639@collabora.com> <640c1a9b-f8b5-aa89-19af-7d6f5c55eb12@gmail.com> From: AngeloGioacchino Del Regno In-Reply-To: <640c1a9b-f8b5-aa89-19af-7d6f5c55eb12@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 07/07/22 12:41, Matthias Brugger ha scritto: > > > On 07/07/2022 10:52, AngeloGioacchino Del Regno wrote: >> Il 05/07/22 14:26, Allen-KH Cheng ha scritto: >>> Add mdp3 mutex compatible for mt8186 SoC. >>> >>> Signed-off-by: Allen-KH Cheng >>> Signed-off-by: Xiandong Wang >> >> >> Please drop this commit. Adding a mdp3-mutex compatible is not needed here. >> > > Thanks for checking. We probably would need a fallback compatible. We can only know > from the HW engineers that can confirm if the IP block is the same as the disp > mutex or a different one. > > I'll drop both patches for now until things got clear. > They're located in a different iospace from each other, but either the platform data needs to *not be* joined together, or if they're together, I would not like having two different compatible strings for essentially the same thing. I would at this point prefer dropping '-disp' from 'mediatek,mt8186-disp-mutex' so that we would be able to declare two 'mediatek,mt8186-mutex' in devicetree... ...or simply have two mediatek,mt8186-disp-mutex (although logically incorrect?). Cheers, Angelo > Regards, > Matthias > >>> --- >>>   .../devicetree/bindings/soc/mediatek/mediatek,mutex.yaml         | 1 + >>>   1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >>> b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >>> index 627dcc3e8b32..234fa5dc07c2 100644 >>> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >>> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >>> @@ -30,6 +30,7 @@ properties: >>>         - mediatek,mt8173-disp-mutex >>>         - mediatek,mt8183-disp-mutex >>>         - mediatek,mt8186-disp-mutex >>> +      - mediatek,mt8186-mdp3-mutex >>>         - mediatek,mt8192-disp-mutex >>>         - mediatek,mt8195-disp-mutex >> >> >>