public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	balbi@ti.com, rob.herring@calxeda.com, kgene.kim@samsung.com,
	kishon@ti.com, jg1.han@samsung.com, s.nawrocki@samsung.com,
	t.figa@samsung.com, jwerner@chromium.org, k.debski@samsung.com
Subject: Re: [PATCH v2 2/4] dt: exynos5250: Enable support for generic USB 3.0 phy
Date: Wed, 04 Dec 2013 13:50:12 +0100	[thread overview]
Message-ID: <2442031.907VFG2eGN@amdc1032> (raw)
In-Reply-To: <1386151747-3209-3-git-send-email-gautam.vivek@samsung.com>


Hi,

Does the old phy-samsung-usb3 driver currently work on Exynos5250?  If yes,
then this patch should be merged with patch #1 to preserve bisectability.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

On Wednesday, December 04, 2013 03:39:05 PM Vivek Gautam wrote:
> Update device tree bindings for DWC3 controller and
> USB 3.0 phy present on Exynos 5250 SoC, to start using
> the phy driver based on generic phy framework.
> 
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250.dtsi |   16 ++++++----------
>  1 files changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 9db5047..7444717 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -475,22 +475,18 @@
>  			compatible = "synopsys,dwc3";
>  			reg = <0x12000000 0x10000>;
>  			interrupts = <0 72 0>;
> -			usb-phy = <&usb2_phy &usb3_phy>;
> +			phys = <&usb3_phy>;
> +			phy-names = "usb3-phy";
>  		};
>  	};
>  
>  	usb3_phy: usbphy@12100000 {
>  		compatible = "samsung,exynos5250-usb3phy";
>  		reg = <0x12100000 0x100>;
> -		clocks = <&clock 1>, <&clock 286>;
> -		clock-names = "ext_xtal", "usbdrd30";
> -		#address-cells = <1>;
> -		#size-cells = <1>;
> -		ranges;
> -
> -		usbphy-sys {
> -			reg = <0x10040704 0x8>;
> -		};
> +		clocks = <&clock 286>, <&clock 1>;
> +		clock-names = "phy", "usb3phy_refclk";
> +		samsung,syscon-phandle = <&pmu_syscon>;
> +		#phy-cells = <0>;
>  	};
>  
>  	usb@12110000 {


  reply	other threads:[~2013-12-04 12:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04 10:09 [PATCH v2 0/4] Add Exynos5 USB 3.0 phy driver based on generic PHY framework Vivek Gautam
2013-12-04 10:09 ` [PATCH v2 1/4] phy: Add new Exynos5 USB 3.0 PHY driver Vivek Gautam
2013-12-23  9:11   ` Vivek Gautam
2013-12-23 16:48     ` Felipe Balbi
2013-12-24  5:43       ` Vivek Gautam
2014-01-20 13:42   ` [PATCH v3] " Vivek Gautam
2014-01-21  7:46     ` Vivek Gautam
2014-01-27  8:57     ` Kishon Vijay Abraham I
2014-01-30  4:19       ` Vivek Gautam
2014-01-30  6:18         ` Kishon Vijay Abraham I
2014-01-30  7:33           ` Vivek Gautam
2014-02-06 14:07     ` Tomasz Figa
2014-02-10  8:27       ` Kishon Vijay Abraham I
2014-02-14 13:53       ` Vivek Gautam
2014-02-14 15:47         ` Tomasz Figa
2014-02-17 10:01           ` Vivek Gautam
2013-12-04 10:09 ` [PATCH v2 2/4] dt: exynos5250: Enable support for generic USB 3.0 phy Vivek Gautam
2013-12-04 12:50   ` Bartlomiej Zolnierkiewicz [this message]
2013-12-05  8:17     ` Vivek Gautam
2013-12-04 10:09 ` [PATCH v2 3/4] dt: exynos5420: Enable support for USB 3.0 PHY controller Vivek Gautam
2013-12-04 10:09 ` [PATCH v2 4/4] dt: exynos5420: Enable support for DWC3 controller Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2442031.907VFG2eGN@amdc1032 \
    --to=b.zolnierkie@samsung.com \
    --cc=balbi@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gautam.vivek@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=jwerner@chromium.org \
    --cc=k.debski@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kishon@ti.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    --cc=s.nawrocki@samsung.com \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox