From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756576AbcBHVqE (ORCPT ); Mon, 8 Feb 2016 16:46:04 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:59804 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756433AbcBHVqA (ORCPT ); Mon, 8 Feb 2016 16:46:00 -0500 From: Arnd Bergmann To: Paul Gortmaker Cc: Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, Eddie Huang , Matthias Brugger , Sascha Hauer , Matt Redfearn , Paul Burton , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] serial: 8250: fix building Ingenic with SERIAL_8250=m Date: Mon, 08 Feb 2016 22:45:07 +0100 Message-ID: <2444356.TvhDejDUJL@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160208164543.GY23093@windriver.com> References: <1454935947-2743255-1-git-send-email-arnd@arndb.de> <1454935947-2743255-2-git-send-email-arnd@arndb.de> <20160208164543.GY23093@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:xVCRvuEjj5oR6MVvS5a8aBM0dwou5jUGoruQtcyZtaouVTx2GX7 /gkuzs76zsQI50z9+ifW1DoMkB7JL8m5ymviwBYTRAZjNxFXPRgs6PYWyCHJLJFX/VJmr1x n2Sb5WlCA53yPjBctYtl2x61y1iXfewRCpRgS9gu2e8AK/4A8RegYawp552D+bTERdQwTdW 2eAXdegDDcQ+nMHI+GCyg== X-UI-Out-Filterresults: notjunk:1;V01:K0:BntImyFX/ak=:6tdSauplqmGNiM7I4TUS7h YK1yCQvBr12htX8XRFi7g8b15xgLNBDH10BjQHxYtiPF9omFcfWo4crFi0Rg0oUMyrieGy3WA 2cRw0xOTiEhfGOqyh7YIFkD/h+jE7AmPNZFvC6fxs0bJIC8mDXenQeUwz1EmCwNaZukI9Tps2 jTLJ2bKNXYSNSqSZj80U2lfRchhm9DdK9sJZYpognCuoLlw2SVN7ouGbWDK4R7cYsS6D0/yMo lsSdaBm8F4yfRAH9zCPXwLAhpD1xhi2yJ0S3ekGZjd+DPVyymwd2dHHk/9kXI5sxiCUlpevcO pgDtYgfKCjoX5ZWviUfPnlZTCUDZCo4A0rUynhQnorPpfkP2EkE6000a6+IEY1rSfeUVKBtZh rBkhes3pMcypww0jHfQp9sWl4JfIA0QaxnWAi8dgiIaY4pdc1mhWvnZ/dIcsYUmmoPSvNksY0 MDVqJXsDZ9IB2jh5QO8V14LyyPzpMiU9cWHjOK+RRpbOOkJmhlPI/VDY6xLW9j1ot1rWQ/Gkb 0M+k706nadYGZFWhb1Ru62MpjAI4+OjPkFQjTgnhMG+yfML1JPmj/WAI6d0MmCi229YBWYRho 7j65GQnhtTUkYtJNQz+QDKUTIxmTEFdI0OUp0Vecor/5DXdVlrm9QUhc5b0hyQu3kZELZifuo GkQNPJZT0qVYnMES8yfPoI9lXKSJAcGt05WOFBC2yr7Jjkk/wwyNKHgDwPSy82rQtX7b3+zev PAlRaVMfcVUmv1I8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 08 February 2016 11:45:44 Paul Gortmaker wrote: > [[PATCH 2/2] serial: 8250: fix building Ingenic with SERIAL_8250=m] On 08/02/2016 (Mon 13:51) Arnd Bergmann wrote: > > > The Ingenic 8250 driver has a 'bool' Kconfig symbol, but that > > breaks when SERIAL_8250 is a loadable module: > > > > drivers/tty/built-in.o: In function `ingenic_uart_probe': > > 8250_ingenic.c:(.text+0x1c1a0): undefined reference to `serial8250_register_8250_port' > > > > This changes the symbol to a 'tristate', plus a dependency on > > Note that Greg just queued a patch yesterday (but sent in 2015) that > removed what was the dead modular code. > > It could also depend on SERIAL_8250=y to resolve the build issue you > found, if nobody cares about having modular SOC console UART drivers. All other UART drivers can be modules, no need for this to be an exception I think. Having it depend on SERIAL_8250=y would make the driver disabled on 'allmodconfig', which is a bit counterproductive for the purpose of allmodconfig. I don't think anyone actually cares about the driver being runtime loaded on real hardware. > Either way, I don't have issue with it being tristate vs bool, but if > you do go with tristate, then my patch will have to be dropped/reverted. Fine with me too. I also now saw in the randconfig builds that the driver is missing an #include , which I guess is going to be there after reverting your patch. I'll send a new series. Arnd