From: Johannes Thumshirn <jthumshirn@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/13] libnvdimm, blk: use devm_add_action to release bdev resources
Date: Thu, 24 Mar 2016 16:15:28 +0100 [thread overview]
Message-ID: <2448247.bv1n5rEkZ3@c203> (raw)
In-Reply-To: <CAPcyv4gXw+a5uuZ_hwmb6n=P2x9fGfD_5TxAKZ+sB8=XePoJVA@mail.gmail.com>
On Donnerstag, 24. März 2016 08:14:10 CET Dan Williams wrote:
> On Thu, Mar 24, 2016 at 4:48 AM, Johannes Thumshirn <jthumshirn@suse.de>
wrote:
> > On Mittwoch, 23. März 2016 18:25:47 CET Dan Williams wrote:
> >> Register a callback to clean up the request_queue and put the gendisk at
> >> driver disable time.
> >>
> >> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> >> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> >
> > [...]
> >
> >> static int nd_blk_remove(struct device *dev)
> >> {
> >>
> >> - struct nd_blk_device *blk_dev = dev_get_drvdata(dev);
> >> -
> >>
> >> if (is_nd_btt(dev))
> >>
> >> nvdimm_namespace_detach_btt(to_nd_btt(dev));
> >>
> >> - else
> >> - nd_blk_detach_disk(blk_dev);
> >> - kfree(blk_dev);
> >> -
> >>
> >> return 0;
> >>
> >> }
> >
> > Can't this be void?
>
> That's not how the core defines this:
>
> struct device_driver {
> ...
> int (*remove) (struct device *dev);
> ...
> };
Ah OK, didn't see this, sorry
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2016-03-24 15:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 1:25 [PATCH 00/13] prep for device-dax, untangle pfn-device setup Dan Williams
2016-03-24 1:25 ` [PATCH 01/13] libnvdimm, pfn: fix nvdimm_namespace_add_poison() vs section alignment Dan Williams
2016-03-24 10:10 ` Johannes Thumshirn
2016-03-24 14:48 ` Dan Williams
2016-03-24 1:25 ` [PATCH 02/13] libnvdimm, pmem: kill pmem->ndns Dan Williams
2016-03-24 10:31 ` Johannes Thumshirn
2016-03-24 1:25 ` [PATCH 03/13] libnvdimm, pfn, convert nd_pfn_probe() to devm Dan Williams
2016-03-24 10:45 ` Johannes Thumshirn
2016-03-24 1:25 ` [PATCH 04/13] libnvdimm, btt, convert nd_btt_probe() " Dan Williams
2016-03-24 11:05 ` Johannes Thumshirn
2016-03-24 1:25 ` [PATCH 05/13] libnvdimm, blk: use devm_add_action to release bdev resources Dan Williams
2016-03-24 11:48 ` Johannes Thumshirn
2016-03-24 15:14 ` Dan Williams
2016-03-24 15:15 ` Johannes Thumshirn [this message]
2016-03-24 15:21 ` Dan Williams
2016-03-24 1:25 ` [PATCH 06/13] libnvdimm, blk: use ->queuedata for driver private data Dan Williams
2016-03-24 11:51 ` Johannes Thumshirn
2016-03-24 1:25 ` [PATCH 07/13] libnvdimm, pmem: " Dan Williams
2016-03-24 12:06 ` Johannes Thumshirn
2016-03-24 1:26 ` [PATCH 08/13] libnvdimm, blk: move i/o infrastructure to nd_namespace_blk Dan Williams
2016-03-24 12:22 ` Johannes Thumshirn
2016-03-24 15:21 ` Dan Williams
2016-03-24 15:22 ` Johannes Thumshirn
2016-03-25 22:02 ` [PATCH v2] " Dan Williams
2016-03-24 1:26 ` [PATCH 09/13] libnvdimm, pmem: use devm_add_action to release bdev resources Dan Williams
2016-03-24 12:35 ` Johannes Thumshirn
2016-03-24 1:26 ` [PATCH 10/13] libnvdimm, pmem: clean up resource print / request Dan Williams
2016-03-24 13:42 ` Johannes Thumshirn
2016-03-24 1:26 ` [PATCH 11/13] libnvdimm, pmem, pfn: make pmem_rw_bytes generic and refactor pfn setup Dan Williams
2016-03-24 13:50 ` Johannes Thumshirn
2016-03-25 22:13 ` [PATCH v2] " Dan Williams
2016-03-24 1:26 ` [PATCH 12/13] libnvdimm, pmem, pfn: move pfn setup to the core Dan Williams
2016-03-24 14:36 ` Johannes Thumshirn
2016-03-24 15:26 ` Dan Williams
2016-03-25 22:15 ` [PATCH v2] " Dan Williams
2016-03-29 8:30 ` Johannes Thumshirn
2016-03-24 1:26 ` [PATCH 13/13] libnvdimm, pmem: kill ->pmem_queue and ->pmem_disk Dan Williams
2016-03-24 14:38 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2448247.bv1n5rEkZ3@c203 \
--to=jthumshirn@suse.de \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox