From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752809AbdJ3XCN (ORCPT ); Mon, 30 Oct 2017 19:02:13 -0400 Received: from gloria.sntech.de ([95.129.55.99]:37198 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbdJ3XCL (ORCPT ); Mon, 30 Oct 2017 19:02:11 -0400 From: Heiko Stuebner To: Jeffy Chen , seanpaul@chromium.org Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org, Andrzej Hajda , Arnd Bergmann , Romain Perier , Russell King , Philipp Zabel , Jonathan Corbet , dri-devel@lists.freedesktop.org, Jingoo Han , David Airlie , Kevin Hilman , Catalin Marinas , Laurent Pinchart , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Seung-Woo Kim , Inki Dae , linux-rockchip@lists.infradead.org, Kyungmin Park , Carlo Caione , Will Deacon , linux-amlogic@lists.infradead.org, Caesar Wang , Matthias Kaehlcke , devicetree@vger.kernel.org, Kukjin Kim , Tomeu Vizoso , zain wang , Hans Verkuil , Archit Taneja , Joonyoung Shim , linux-arm-kernel@lists.infradead.org, Marek Szyprowski , Daniel Vetter , Mark Yao , linux-renesas-soc@vger.kernel.org, Neil Armstrong , Kieran Bingham , Rob Herring , Jose Abreu , Mark Rutland Subject: Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display Date: Tue, 31 Oct 2017 00:01:08 +0100 Message-ID: <2449324.8EdsLz1NaV@phil> User-Agent: KMail/5.2.3 (Linux/4.13.0-1-amd64; KDE/5.37.0; x86_64; ; ) In-Reply-To: <20171019034812.13768-1-jeffy.chen@rock-chips.com> References: <20171019034812.13768-1-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jeffy, Sean, Am Donnerstag, 19. Oktober 2017, 11:48:02 CET schrieb Jeffy Chen: > > Make edp display works on chromebook kevin(at least for boot animation). > > Also solve some issues i meet during the bringup. > > Changes in v6: > Don't change order of rockchip_drm_psr_register(). > > Changes in v5: > Call the destroy hook in the error handling path like in unbind(). > Call the destroy hook in the error handling path like in unbind(). > Update cleanup order in unbind(). > Add disable to unbind(), and inline clk_prepare_enable() with bind(). > > Jeffy Chen (10): > arm64: dts: rockchip: Enable edp disaplay on kevin > drm/rockchip: analogix_dp: Remove unnecessary init code > drm/bridge: analogix: Do not use device's drvdata > drm/bridge: analogix_dp: Fix connector and encoder cleanup > drm/rockchip: analogix_dp: Add a sanity check for > rockchip_drm_psr_register() > drm/rockchip: dw-mipi-dsi: Fix error handling path > drm/rockchip: inno_hdmi: Fix error handling path > drm/bridge/synopsys: dw-hdmi: Add missing bridge detach > drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata > drm/rockchip: dw_hdmi: Fix error handling path As I was just looking at the edp dts change in patch1 again, does this series also contain a fix for the issue below [0] ? I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in. Heiko [0] [ 27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x00000002 [ 27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc pwm_bl pwm_cros_ec rockchip_thermal ip_tables x_tabl es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie pcie_rockchip [ 28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: G W 4.14.0-rc7-03201-g12490811b353 #559 [ 28.008774] Hardware name: Google Kevin (DT) [ 28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm] [ 28.008828] Call trace: [ 28.008838] [] dump_backtrace+0x0/0x378 [ 28.008842] [] show_stack+0x14/0x20 [ 28.008847] [] dump_stack+0x9c/0xbc [ 28.008852] [] __schedule_bug+0x4c/0x70 [ 28.008856] [] __schedule+0x558/0x5e8 [ 28.008859] [] schedule+0x38/0xa0 [ 28.008864] [] schedule_hrtimeout_range_clock+0x84/0xe8 [ 28.008867] [] schedule_hrtimeout_range+0x10/0x18 [ 28.008870] [] usleep_range+0x64/0x78 [ 28.008882] [] analogix_dp_transfer+0x16c/0xa88 [analogix_dp] [ 28.008891] [] analogix_dpaux_transfer+0x10/0x18 [analogix_dp] [ 28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 [drm_kms_helper] [ 28.008994] [] drm_dp_dpcd_write+0x1c/0x28 [drm_kms_helper] [ 28.009002] [] analogix_dp_disable_psr+0x60/0xb0 [analogix_dp] [ 28.009036] [] analogix_dp_psr_work+0x4c/0xc0 [rockchipdrm] [ 28.009040] [] process_one_work+0x1d4/0x348 [ 28.009043] [] worker_thread+0x48/0x470 [ 28.009048] [] kthread+0x12c/0x130 [ 28.009052] [] ret_from_fork+0x10/0x18