From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753393AbbCJUWg (ORCPT ); Tue, 10 Mar 2015 16:22:36 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:52114 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752461AbbCJUWP convert rfc822-to-8bit (ORCPT ); Tue, 10 Mar 2015 16:22:15 -0400 From: Arnd Bergmann To: Maxime Coquelin Cc: Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , Andreas =?ISO-8859-1?Q?F=E4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Daniel Lezcano , Thomas Gleixner , Linus Walleij , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" Subject: Re: [PATCH v2 07/18] drivers: reset: Add STM32 reset driver Date: Tue, 10 Mar 2015 21:21:33 +0100 Message-ID: <2455342.zT71E5iyaL@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1424455277-29983-1-git-send-email-mcoquelin.stm32@gmail.com> <2383270.cAJPOxrkvo@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" X-Provags-ID: V03:K0:tEtps2/gIUpCZrFHyWcOXEpWZVZ8RtvLnZu6+1dB9YhqhzbWN+T 9aY/smUjzalEArV/RL5/DLSqswV/5G/nROs8V+Hv10wLrUqCP1IJtbORmUcAVugVINQvfyX LnCxbHEj/f5ouo5kGiE27E2LgoPdcA2u/qsFPPDYZ+crCKruTkLNTrL5hm4aCylS67q8Bti +Chq9tNLbF7i9PCrkHsIQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 10 March 2015 16:44:24 Maxime Coquelin wrote: > 2015-03-10 16:02 GMT+01:00 Arnd Bergmann : > > On Friday 20 February 2015 19:01:06 Maxime Coquelin wrote: > >> +/* AHB1 */ > >> +#define GPIOA_RESET 0 > >> +#define GPIOB_RESET 1 > >> +#define GPIOC_RESET 2 > >> +#define GPIOD_RESET 3 > >> +#define GPIOE_RESET 4 > >> +#define GPIOF_RESET 5 > >> +#define GPIOG_RESET 6 > >> +#define GPIOH_RESET 7 > >> +#define GPIOI_RESET 8 > >> +#define GPIOJ_RESET 9 > >> +#define GPIOK_RESET 10 > >> > > > > As these are just the hardware numbers, it's better to not make them > > part of the binding at all. Instead, just document in the binding that > > one is supposed to pass the hardware number as the argument. > > The reset controller is part of the RCC (Reset & Clock Controller) IP. > In this version, I only provided the reset registers to the reset > controller driver, but as per Andreas Färber remark, I should avec a > single DT node for both the resets and clocks. > > In the next version I am preparing, the defines doesn't look as > trivial as in this version, GPIOA_RESET being 128 for instance. > > Is it fine for you if I keep the defines part of the binding? > > It's always better to avoid these files entirely, as they are a frequent source of merge dependencies, and they make it less obvious what's going on than having binary values in the dtb that make sense. Arnd