From: Martin Walch <walch.martin@web.de>
To: linux-kbuild@vger.kernel.org
Cc: "Michal Marek" <mmarek@suse.cz>,
"Arve Hjønnevåg" <arve@android.com>,
"Jiri Kosina" <trivial@kernel.org>,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
"Benjamin Poirier" <bpoirier@suse.de>,
"Dirk Gouders" <dirk@gouders.net>,
"Wang YanQing" <udknight@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jean Delvare" <jdelvare@suse.de>,
"Kees Cook" <keescook@chromium.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len
Date: Thu, 03 Oct 2013 19:25:53 +0200 [thread overview]
Message-ID: <2458916.eNjWPdyz4y@tacticalops> (raw)
From: Martin Walch <walch.martin@web.de>
Date: Thu, 3 Oct 2013 18:35:16 +0200
Subject: [PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len
The struct gstr has a capacity that may differ from the actual string length.
However, a string manipulation in the function search_conf made the assumption
that it is the same, which led to messing up some search results, especially
when the content of the gstr in use had not yet reached at least 63 chars.
Signed-off-by: Martin Walch <walch.martin@web.de>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 9e69f19..db1512a 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -584,7 +584,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
for (j = 4; --i >= 0; j += 2) {
menu = submenu[i];
if (head && location && menu == location)
- jump->offset = r->len - 1;
+ jump->offset = strlen(r->s);
str_printf(r, "%*c-> %s", j, ' ',
_(menu_get_prompt(menu)));
if (menu->sym) {
--
1.8.1.5
next reply other threads:[~2013-10-03 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 17:25 Martin Walch [this message]
2013-10-05 17:54 ` [PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len Wang YanQing
2013-10-07 13:43 ` Benjamin Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2458916.eNjWPdyz4y@tacticalops \
--to=walch.martin@web.de \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=bpoirier@suse.de \
--cc=dirk@gouders.net \
--cc=jdelvare@suse.de \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=trivial@kernel.org \
--cc=udknight@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox