public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tom Rix <trix@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	ying-tsun.huang@amd.com, peterz@infradead.org, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm/mtrr: remove definition of DEBUG
Date: Thu, 14 Jan 2021 11:25:16 -0800	[thread overview]
Message-ID: <24593769-e2fe-7fd4-d212-0e6da58764cd@redhat.com> (raw)
In-Reply-To: <20210114184626.GH12284@zn.tnic>


On 1/14/21 10:46 AM, Borislav Petkov wrote:
> On Thu, Jan 14, 2021 at 08:27:43AM -0800, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> Defining DEBUG should only be done in development.
>> So remove DEBUG.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>>  arch/x86/kernel/cpu/mtrr/generic.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
>> index a29997e6cf9e..b90f3f437765 100644
>> --- a/arch/x86/kernel/cpu/mtrr/generic.c
>> +++ b/arch/x86/kernel/cpu/mtrr/generic.c
>> @@ -3,7 +3,6 @@
>>   * This only handles 32bit MTRR on 32bit hosts. This is strictly wrong
>>   * because MTRRs can span up to 40 bits (36bits on most modern x86)
>>   */
>> -#define DEBUG
>>  
>>  #include <linux/export.h>
>>  #include <linux/init.h>
> Wanna merge all 4 in arch/x86/
>
> arch/x86/kernel/cpu/mtrr/generic.c:6:#define DEBUG
> arch/x86/kernel/cpu/mtrr/mtrr.c:34:#define DEBUG
> arch/x86/kernel/pci-iommu_table.c:8:#define DEBUG 1
> arch/x86/mm/mmio-mod.c:13:#define DEBUG 1
>
> into a single patch?

Yes, i'll take care of that.

Tom

> Thx.
>


      reply	other threads:[~2021-01-14 19:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 16:27 [PATCH] x86/mm/mtrr: remove definition of DEBUG trix
2021-01-14 18:46 ` Borislav Petkov
2021-01-14 19:25   ` Tom Rix [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24593769-e2fe-7fd4-d212-0e6da58764cd@redhat.com \
    --to=trix@redhat.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=ying-tsun.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox