From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755736AbbEUOwr (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 May 2015 10:52:47 -0400
Received: from mout.kundenserver.de ([212.227.126.130]:49447 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753638AbbEUOwo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 May 2015 10:52:44 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: y2038@lists.linaro.org, baolin.wang@linaro.org, albert.aribaud@3adev.fr,
        John Stultz <john.stultz@linaro.org>, bamvor.zhangjian@linaro.org,
        ruchandani.tina@gmail.com,
        "linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        libc-alpha@sourceware.org, Linux-Arch <linux-arch@vger.kernel.org>,
        Manfred Spraul <manfred@colorfullife.com>,
        Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: [PATCH 2/9] y2038: asm-generic: extend sysvipc data structures
Date: Thu, 21 May 2015 16:52:31 +0200
Message-ID: <2463292.dEmUgCQccn@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAMuHMdUtJ2x+axBLj5qdsRwod=XdRkmeYJm1N7H5V_CXLo5J0g@mail.gmail.com>
References: <1432134445-804487-1-git-send-email-arnd@arndb.de> <1432134445-804487-3-git-send-email-arnd@arndb.de> <CAMuHMdUtJ2x+axBLj5qdsRwod=XdRkmeYJm1N7H5V_CXLo5J0g@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:2YDNaEPAaHxITI1V9vT4Gq4E7PgTq6x/nm9bPJR7EB7QGzROL6O
 zjPqsAuAq6TNIFHYs+V9OMXp0kZtWrkvOYpgshKur3ZvgONgj6Ti2nVhT+giJ74bZAaouel
 f5p6sDLiD6axr3+Znz3kkSDgb5nWk79O98mtcflsUEODIJ3LLH9oRylqVe2fLzmsADKEEsA
 V329UMMl/nd26AiZKGjXw==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 21 May 2015 10:56:34 Geert Uytterhoeven wrote:
> > + * value using
> > + *
> > + * user_semid_ds.sem_otime = kernel_semid64_ds.sem_otime +
> > + *             (long long)(kernel_semid64_ds.sem_otime_high << 32)
> 
> The cast to "long long" should be inside the parentheses, to promote the
> (32-bit) sem_otime_high to a first 64-bit integer first.
> Else it will be shifted into oblivion (oh no, C undefined behavior).
> 
> 

Fixed now to say

 * user_semid_ds.sem_otime = kernel_semid64_ds.sem_otime +
 *             ((long long)kernel_semid64_ds.sem_otime_high << 32)

Thanks!

	Arnd