From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbbGXLXQ (ORCPT ); Fri, 24 Jul 2015 07:23:16 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:35823 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769AbbGXLXO (ORCPT ); Fri, 24 Jul 2015 07:23:14 -0400 From: Matthias Brugger To: Masahiro Yamada Cc: linux-serial@vger.kernel.org, Jiri Slaby , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] serial: 8250_uniphier: call clk_disable_unprepare() on failure path Date: Fri, 24 Jul 2015 13:23:09 +0200 Message-ID: <2473660.NnHIN4Y0gO@ubix> User-Agent: KMail/4.13.3 (Linux/3.13.0-57-generic; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1437721108-19037-1-git-send-email-yamada.masahiro@socionext.com> References: <1437721108-19037-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, July 24, 2015 03:58:28 PM Masahiro Yamada wrote: > If serial8250_register_8250_port() fails, disable and unprepare the > clock before exiting. > > Fixes: 1a8d2903cb6a ("serial: 8250_uniphier: add UniPhier serial driver") > Signed-off-by: Masahiro Yamada > --- Reviewed-by: Matthias Brugger