From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD1DC433EF for ; Mon, 25 Oct 2021 10:02:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40B9460FDC for ; Mon, 25 Oct 2021 10:02:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232728AbhJYKFE (ORCPT ); Mon, 25 Oct 2021 06:05:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232676AbhJYKEz (ORCPT ); Mon, 25 Oct 2021 06:04:55 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EAB3C061745 for ; Mon, 25 Oct 2021 03:02:33 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id r4so15839345edi.5 for ; Mon, 25 Oct 2021 03:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=66S15h2BChIH5efEJ1O2/Dq6oRoO6DFpUA1AaJu7EyI=; b=WdJsrfX4qv58ER5mDlLoQaTWORtGDBHWuB/0toUEw6L9yw5hBg7FfUqMBhhSRjj1ow cTIAAAiDSj7j7/XqTi/lj3me01aF4cbDE3Szpwh1yQxgJC8KEeyv5yY23xzrQYOtjLRt vEf248rYO2u9wMXuw8pJedS3usmaqq1MufyuCE/HDDXQskB9x2ScRnkLhZCWCow8gV/b hvYvIR1GTaULgYddVAj9yXIXqbtc4hmm+zeM9zY/rCESs1PpyTpOVlyt4hJHB2GSBjJS 1W9qYaX4LsLLc6ir4Nsp2mmnfI43v/VhbydTbtxJMWinXjZq86pTlyW2MSfqMPD1RgA7 NJsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=66S15h2BChIH5efEJ1O2/Dq6oRoO6DFpUA1AaJu7EyI=; b=ge2VqTgVOQq9YaTPh9vdK+jCm7V8lmjjl5qDokPXT1MMdOMQExCrnIJEY3QZ17sFI4 e0Bvz/pVBrU1aAJa+KoJVlfDGiTA4BoBWfcmxQz02iCoff/TRtSs0QP3qj7RwDofjrax xhe/jYKXC+yOoyEyF01cfPBf+cBHpAXFeSkEa8i1C5L2gRnlidS+yKTFgREArF/NmrfZ N8wHeyZnFn9q6BKzWA4E3gfesSyL1gV9Bc5cLiK8Sb6sSGoZWVxlcE3IOeFUE10iDNXQ ElMPVhfy5M8jUJhJ1VRbXv0gCPR0hJrHpI9uyEB4EQszNLLc/YWmypTd9F1FTtmvDzAq HJQQ== X-Gm-Message-State: AOAM5300J75E68fluSmthEh4SvitbSWIUYUhGUjVhXVVsNw8/bYHf1CV XRqyoDPwkgXkX0xBbW4Vy0w= X-Google-Smtp-Source: ABdhPJyehztEVg3aQrRPxVPv/paDlNewPxneJekrg5dlnj91FYmgmk04MdK1vyDP7hQSjbMQrqsU8g== X-Received: by 2002:aa7:cc96:: with SMTP id p22mr25067132edt.91.1635156150870; Mon, 25 Oct 2021 03:02:30 -0700 (PDT) Received: from localhost.localdomain (host-80-181-148-119.retail.telecomitalia.it. [80.181.148.119]) by smtp.gmail.com with ESMTPSA id hc18sm5147357ejc.4.2021.10.25.03.02.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 03:02:30 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg KH , kushal kothari Cc: fabioaiuto83@gmail.com, ross.schm.dev@gmail.com, hdegoede@redhat.com, marcocesati@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, Mike Rapoport , kushalkothari2850@gmail.com Subject: Re: [PATCH] staging: rtl8723bs: core: Refactor nested if-else Date: Mon, 25 Oct 2021 12:02:27 +0200 Message-ID: <2475218.nDWPeaHJO9@localhost.localdomain> In-Reply-To: References: <20211025072528.152028-1-kushalkothari285@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="ISO-8859-1" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, October 25, 2021 9:56:00 AM CEST kushal kothari wrote: > >Very long line, please break it up at 72 columns. > > >And your space around the '.' is odd :( > > Yes,fixing it. > ^^^^^^^^^^^^^^^^^^^^ You are still using spaces the wrong way :) English, as well as all natural languages that use Latin characters, use punctuation and a strict style that dictates how to use the spaces around it. Please read correctly written English texts, learn and use conventions Thanks, Fabio > > >> checkpatch warning : Too many leading tabs - consider code refactoring > > >What does this mean? > Asking about the warning ,correct? > The current code is using very deep indentations (which can be avoided) and > due to this there are many leading tabs. So the checkpatch.pl warns of "Too > many leading tabs - consider code refactoring" > > > On Mon, Oct 25, 2021 at 1:03 PM Greg KH wrote: > > > On Mon, Oct 25, 2021 at 12:55:28PM +0530, Kushal Kothari wrote: > > > Refactor nested if else by combining nested if into a single if > > condition and removing unnecessary else conditionals which leads to > > removing unnecessary tabs .There is no change in logic of new code. > > > > Very long line, please break it up at 72 columns. > > > > And your space around the '.' is odd :( > > > > > checkpatch warning : Too many leading tabs - consider code refactoring > > > > What does this mean? > > > > > > > > Signed-off-by: Kushal Kothari > > > --- > > > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 65 ++++++++----------- > > > 1 file changed, 26 insertions(+), 39 deletions(-) > > > > > > > thanks, > > > > greg k-h > > >