From: Krzysztof Kozlowski <krzk@kernel.org>
To: Takashi Iwai <tiwai@suse.de>, Lei Huang <huanglei814@163.com>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, Lei Huang <huanglei@kylinos.cn>
Subject: Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')
Date: Fri, 10 Apr 2026 09:11:39 +0200 [thread overview]
Message-ID: <2475f220-b0ff-4ee6-b897-75de87d68f81@kernel.org> (raw)
In-Reply-To: <460e5a49-dd85-41fe-9d35-0c4e7efc0ceb@kernel.org>
On 01/04/2026 12:43, Krzysztof Kozlowski wrote:
> On 31/03/2026 10:20, Takashi Iwai wrote:
>> On Tue, 31 Mar 2026 09:54:05 +0200,
>> Lei Huang wrote:
>>>
>>> From: Lei Huang <huanglei@kylinos.cn>
>>>
>>> Fix checkpatch code style errors:
>>>
>>> ERROR: else should follow close brace '}'
>>> #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
>>> + }
>>> + else
>>>
>>> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
>>> Signed-off-by: Lei Huang <huanglei@kylinos.cn>
>>
>> Thanks, applied to for-next branch.
>
> I hope you dropped the fake Fixes tag. Or at least give people chance to
> review it.
I see you entirely ignored all the comments about fake bug being fixed here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-10 7:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 7:54 [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}') Lei Huang
2026-03-31 8:20 ` Takashi Iwai
2026-04-01 10:43 ` Krzysztof Kozlowski
2026-04-10 7:11 ` Krzysztof Kozlowski [this message]
2026-04-10 7:30 ` Takashi Iwai
2026-04-10 7:41 ` Krzysztof Kozlowski
2026-04-10 7:46 ` Takashi Iwai
2026-04-10 8:03 ` Krzysztof Kozlowski
2026-04-10 8:10 ` Takashi Iwai
2026-04-01 10:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2475f220-b0ff-4ee6-b897-75de87d68f81@kernel.org \
--to=krzk@kernel.org \
--cc=huanglei814@163.com \
--cc=huanglei@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox