From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>
Cc: Jeff Garzik <jgarzik@pobox.com>
Cc: Mikael Pettersson <mikpe@it.uu.se>
Cc: <linux-ide@vger.kernel.org>
Subject: [PATCH 1/2] ATA: sata_promise, do not freeze ports
Date: Sat, 5 May 2007 16:50:05 +0200 (CEST) [thread overview]
Message-ID: <248077021012417739@wsc.cz> (raw)
If no objections, here comes the revert of the return 1 issue.
--
sata_promise, do not freeze ports
revert return 1 thing in the error isr, that causes port freezing, so that the
system is unusable when exception is thrown.
See http://lkml.org/lkml/2007/4/30/268
Cc: Jeff Garzik <jgarzik@pobox.com>
Cc: Mikael Pettersson <mikpe@it.uu.se>
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
commit a38d21f4b5d5029b0b083fe2651e78c7657fda3b
tree 0a2019a34227906bc5fb0e60d90cc7f4759ee934
parent b5c1fc64195b18d3919bfa7dddfb76e9f2a05786
author Jiri Slaby <jirislaby@gmail.com> Sat, 05 May 2007 16:43:22 +0200
committer Jiri Slaby <jirislaby@gmail.com> Sat, 05 May 2007 16:43:22 +0200
drivers/ata/sata_promise.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/sata_promise.c b/drivers/ata/sata_promise.c
index f56549b..a0024ae 100644
--- a/drivers/ata/sata_promise.c
+++ b/drivers/ata/sata_promise.c
@@ -668,10 +668,8 @@ static inline unsigned int pdc_host_intr( struct ata_port *ap,
else
err_mask &= ~PDC2_ERR_MASK;
port_status = readl(port_mmio + PDC_GLOBAL_CTL);
- if (unlikely(port_status & err_mask)) {
+ if (unlikely(port_status & err_mask))
pdc_error_intr(ap, qc, port_status, err_mask);
- return 1;
- }
switch (qc->tf.protocol) {
case ATA_PROT_DMA:
next reply other threads:[~2007-05-05 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-05 14:50 Jiri Slaby [this message]
2007-05-05 14:50 ` [PATCH 2/2] V4L2: videodev, allow debugging Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=248077021012417739@wsc.cz \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox