* [PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir()
@ 2023-07-13 3:35 Wang Ming
2023-07-13 15:49 ` Jay Vosburgh
0 siblings, 1 reply; 2+ messages in thread
From: Wang Ming @ 2023-07-13 3:35 UTC (permalink / raw)
To: Jay Vosburgh, Andy Gospodarek, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Yufeng Mo, Guangbin Huang, netdev,
linux-kernel
Cc: opensource.kernel, Wang Ming
The debugfs_create_dir() function returns error pointers,
it never returns NULL. Most incorrect error checks were fixed,
but the one in bond_create_debugfs() was forgotten.
Fix the remaining error check.
Signed-off-by: Wang Ming <machel@vivo.com>
Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
---
drivers/net/bonding/bond_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
index 594094526648..d4a82f276e87 100644
--- a/drivers/net/bonding/bond_debugfs.c
+++ b/drivers/net/bonding/bond_debugfs.c
@@ -88,7 +88,7 @@ void bond_create_debugfs(void)
{
bonding_debug_root = debugfs_create_dir("bonding", NULL);
- if (!bonding_debug_root)
+ if (IS_ERR(bonding_debug_root))
pr_warn("Warning: Cannot create bonding directory in debugfs\n");
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir()
2023-07-13 3:35 [PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir() Wang Ming
@ 2023-07-13 15:49 ` Jay Vosburgh
0 siblings, 0 replies; 2+ messages in thread
From: Jay Vosburgh @ 2023-07-13 15:49 UTC (permalink / raw)
To: Wang Ming
Cc: Andy Gospodarek, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yufeng Mo, Guangbin Huang, netdev, linux-kernel,
opensource.kernel
Wang Ming <machel@vivo.com> wrote:
>The debugfs_create_dir() function returns error pointers,
>it never returns NULL. Most incorrect error checks were fixed,
>but the one in bond_create_debugfs() was forgotten.
>
>Fix the remaining error check.
>
>Signed-off-by: Wang Ming <machel@vivo.com>
Seems fine to me; note that almost nobody uses this as bonding
debugfs is hidden behind !CONFIG_NET_NS.
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
-J
>Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
>---
> drivers/net/bonding/bond_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
>index 594094526648..d4a82f276e87 100644
>--- a/drivers/net/bonding/bond_debugfs.c
>+++ b/drivers/net/bonding/bond_debugfs.c
>@@ -88,7 +88,7 @@ void bond_create_debugfs(void)
> {
> bonding_debug_root = debugfs_create_dir("bonding", NULL);
>
>- if (!bonding_debug_root)
>+ if (IS_ERR(bonding_debug_root))
> pr_warn("Warning: Cannot create bonding directory in debugfs\n");
> }
>
>--
>2.25.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-13 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-13 3:35 [PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir() Wang Ming
2023-07-13 15:49 ` Jay Vosburgh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox