From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751367AbeAWBIl (ORCPT ); Mon, 22 Jan 2018 20:08:41 -0500 Received: from mga09.intel.com ([134.134.136.24]:18474 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751253AbeAWBIk (ORCPT ); Mon, 22 Jan 2018 20:08:40 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,398,1511856000"; d="scan'208";a="12390749" Subject: Re: [PATCH] perf util: Use target->per_thread and target->system_wide flags To: Mathieu Poirier Cc: Arnaldo Carvalho de Melo , jolsa@kernel.org, Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Linux-kernel@vger.kernel.org, Andi Kleen , kan.liang@intel.com, yao.jin@intel.com References: <1516659340-30289-1-git-send-email-yao.jin@linux.intel.com> From: "Jin, Yao" Message-ID: <248c18bd-b2f2-694a-e08f-989e829041ca@linux.intel.com> Date: Tue, 23 Jan 2018 09:08:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/23/2018 7:56 AM, Mathieu Poirier wrote: > On 22 January 2018 at 15:15, Jin Yao wrote: >> Mathieu Poirier reports issue in commit ("73c0ca1eee3d perf thread_map: >> Enumerate all threads from /proc") that it has negative impact on >> 'perf record --per-thread'. It has the effect of creating a kernel event >> for each thread in the system for 'perf record --per-thread'. >> >> Mathieu Poirier's patch ("perf util: Do not reuse target->per_thread flag") >> can fix this issue by creating a new target->all_threads flag. >> >> This patch is based on Mathieu Poirier's patch but it doesn't use a new >> target->all_threads flag. This patch just uses 'target->per_thread && >> target->system_wide' as a condition to check for all threads case. >> >> Signed-off-by: Jin Yao >> --- >> tools/perf/util/evlist.c | 2 +- >> tools/perf/util/thread_map.c | 4 ++-- >> tools/perf/util/thread_map.h | 2 +- >> 3 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c >> index 120efd8..9dff74a 100644 >> --- a/tools/perf/util/evlist.c >> +++ b/tools/perf/util/evlist.c >> @@ -1106,7 +1106,7 @@ int perf_evlist__create_maps(struct perf_evlist *evlist, struct target *target) >> struct thread_map *threads; >> >> threads = thread_map__new_str(target->pid, target->tid, target->uid, >> - target->per_thread); >> + target->per_thread && target->system_wide); >> >> if (!threads) >> return -1; >> diff --git a/tools/perf/util/thread_map.c b/tools/perf/util/thread_map.c >> index 3e1038f..729dad8 100644 >> --- a/tools/perf/util/thread_map.c >> +++ b/tools/perf/util/thread_map.c >> @@ -323,7 +323,7 @@ struct thread_map *thread_map__new_by_tid_str(const char *tid_str) >> } >> >> struct thread_map *thread_map__new_str(const char *pid, const char *tid, >> - uid_t uid, bool per_thread) >> + uid_t uid, bool all_threads) >> { >> if (pid) >> return thread_map__new_by_pid_str(pid); >> @@ -331,7 +331,7 @@ struct thread_map *thread_map__new_str(const char *pid, const char *tid, >> if (!tid && uid != UINT_MAX) >> return thread_map__new_by_uid(uid); >> >> - if (per_thread) >> + if (all_threads) >> return thread_map__new_all_cpus(); >> >> return thread_map__new_by_tid_str(tid); >> diff --git a/tools/perf/util/thread_map.h b/tools/perf/util/thread_map.h >> index 0a806b9..5ec91cf 100644 >> --- a/tools/perf/util/thread_map.h >> +++ b/tools/perf/util/thread_map.h >> @@ -31,7 +31,7 @@ struct thread_map *thread_map__get(struct thread_map *map); >> void thread_map__put(struct thread_map *map); >> >> struct thread_map *thread_map__new_str(const char *pid, >> - const char *tid, uid_t uid, bool per_thread); >> + const char *tid, uid_t uid, bool all_threads); >> >> struct thread_map *thread_map__new_by_tid_str(const char *tid_str); > > Reviewed-and-tested-by: Mathieu Poirier "mathieu.poirier@linaro.org" > Thanks a lot for reviewing the patch. Thanks Jin Yao