From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C0E040DFC8 for ; Tue, 31 Mar 2026 03:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774928197; cv=none; b=mLTzWBWgFwfTao0zcAnvOEomRVrOAkrIagjipUeA6rV8eDfIc4dFEB63x6ejzMh4LpAnJUlnraXwtqyWLpI6xvsDFk5lp8K+dp24ycKGMZ109CTNu9OUgna2zdNDK9azgwmW6VAVHZixEA0BbQSSNNCiYBBbiXbfNYbdLRM0JjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774928197; c=relaxed/simple; bh=ihLYSveTWjZa4kTzzAkdyJdOaXiS/qM7fQtyS3kL4go=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iuwZHb+qI5KeszG28JKfWm8dnSbPms9Du2aaHVhJBlhd/eRVUHtQvbI6cZVX7gXdg+wglQ5HQzEN1dUyWOQoCY8Sw0+uh9iH0N4IbilSV0sbvBJ6xFHlp9cUSH/JSiCArsi9DvN8jcT/EfxlPplYQwkiR6ypgCUUO/ihCelNeSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vQeUhbg7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vQeUhbg7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 822D1C19423; Tue, 31 Mar 2026 03:36:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774928196; bh=ihLYSveTWjZa4kTzzAkdyJdOaXiS/qM7fQtyS3kL4go=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=vQeUhbg757ymedWFZc+YNZ8NuiwzKsmRiVO4Y0w+NVu0NY+72+6eplyw6vEazNAJM wW5MQD7a9/qGiTGt+D3NRHlHMzxZ0QCvoHKXFEUMBC1I+4X5oGjeaHMItyv1GHLFsH 7sQQEiPOejP6ggsHr4UHiGc2KVw0BHp4/roLq7lBaHy7VdsSydBlcN/5NAf6SIS5fv VxoV2AnZ1kMR/NRDBapyMDnpd76sBzxZZ6AFQTSSMFma3cHUAP9NzbYk04iAHnVpV+ uSF+OJrHS0hJFx/cFY7sl/9C6KNsvldp0+FF/OKt2sdA10SpdsLfT/mBxFOapybnzP XC2SCtCRAroGQ== Message-ID: <248cd5c4-e1ac-4d08-a88a-efb472f94752@kernel.org> Date: Tue, 31 Mar 2026 14:36:33 +1100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] riscv: signal: refactor debug logging to use macros To: Austin Kim , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Michael Ellerman In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/3/2026 15:34, Austin Kim wrote: > From: Austin Kim > > Replace manual #if DEBUG_SIG blocks with a unified DEBUGP macro. > This will improve code readability. > > Signed-off-by: Austin Kim > --- > arch/riscv/kernel/compat_signal.c | 10 ++++++---- > arch/riscv/kernel/signal.c | 10 ++++++---- > 2 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/arch/riscv/kernel/compat_signal.c b/arch/riscv/kernel/compat_signal.c > index 6ec4e3425..c82235be7 100644 > --- a/arch/riscv/kernel/compat_signal.c > +++ b/arch/riscv/kernel/compat_signal.c > @@ -12,7 +12,11 @@ > #include > #include > > -#define COMPAT_DEBUG_SIG 0 > +#ifdef DEBUG_SIG > +# define DEBUGP(fmt, args...) pr_info("%s: " fmt, __func__, ##args) > +#else > +# define DEBUGP(fmt, args...) > +#endif > > struct compat_sigcontext { > struct compat_user_regs_struct sc_regs; > @@ -233,11 +237,9 @@ int compat_setup_rt_frame(struct ksignal *ksig, sigset_t *set, > regs->a1 = (unsigned long)(&frame->info); /* a1: siginfo pointer */ > regs->a2 = (unsigned long)(&frame->uc); /* a2: ucontext pointer */ > > -#if COMPAT_DEBUG_SIG > - pr_info("SIG deliver (%s:%d): sig=%d pc=%p ra=%p sp=%p\n", > + DEBUGP("SIG deliver (%s:%d): sig=%d pc=%p ra=%p sp=%p\n", > current->comm, task_pid_nr(current), ksig->sig, > (void *)regs->epc, (void *)regs->ra, frame); > -#endif > > return 0; > } Is there any reason not to use pr_devel()? Or pr_debug() if enabling it at runtime is desirable (with CONFIG_DYNAMIC_DEBUG=y). cheers