From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFB402D5A16 for ; Tue, 18 Nov 2025 20:18:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763497111; cv=none; b=mOSA5wa4aoZdc9jMBjP58b1J9ptU6LpbhBaqsFaXw+MVhouN526A2JdtUdU0m8FF3kX8t3OyvOGmEZefwZrDESM0u4a/0or4rsUHZ/OttJR7/AghQV0qezXBHmyw/oMKiBqpI/wZvbpm0XOpcD7gqp5rA6xjLATBKQypWowFMpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763497111; c=relaxed/simple; bh=KdE+M0lVIS0HGmtD8Ko2F3jFdIzWzLb9S0ujof4OTvs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hpeiSkzx3WQrOgCYujT6OiXtHSls9M9I4odRyvbVCh+pjNEg1DBcAyT2FhXwF3kQgvc0d44gF4M+h84zunR8PWJavNSxKg83I75UmjpZcsVDAXglT66DznGvX2tLvP78OVT5KMQyhZGrCNMUFR2aYIVT1eSx8FHXds0FjMykhuo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CzkuG0mN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CzkuG0mN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F39B5C2BC87; Tue, 18 Nov 2025 20:18:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763497111; bh=KdE+M0lVIS0HGmtD8Ko2F3jFdIzWzLb9S0ujof4OTvs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CzkuG0mNeQpbD3Hy+tj4eX/rn/+E3hFsBaVnbuNLfyC/t2+TLwKI8d549T7QP8eW8 sQisDVOZD0G/5KwwegU4hVX5/hojgUlgx3ADXDvOu07qrfjr2KHDTZ0gFdWN8ssswZ 7ETlZ7miEGm+0CO0XPnoARSKuW6XAKd4KL1K8g8jDQbVaFvTIC+vFyIo2f75DpI24l qeR6dM0weLyxEj3kGSYAmHUkmoFYHnYo+ecYAeor+kZbc2wfhJLOlVOSyRxP7mwcou +y47JzdCggFaeknWxJA3dsNmvBpaw5REHP4Fm0FuBfRI4Rxskb7TP1LsTX07tEPXGa BgHC+IGmVtNAw== Message-ID: <249625c7-eb2a-41f0-94cd-4551e5a38f73@kernel.org> Date: Tue, 18 Nov 2025 21:18:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/huge_memory.c: introduce folio_split_unmapped To: Balbir Singh , linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org Cc: Andrew Morton , Zi Yan , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Oscar Salvador , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Ralph Campbell , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Matthew Brost , Francois Dugast References: <20251114012228.2634882-1-balbirs@nvidia.com> <5b481d76-638d-46d4-ad98-5508fc8b715e@kernel.org> <4daec24f-c97e-4c26-819b-e7762b301036@nvidia.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <4daec24f-c97e-4c26-819b-e7762b301036@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14.11.25 10:10, Balbir Singh wrote: > On 11/14/25 19:36, David Hildenbrand (Red Hat) wrote: >> On 14.11.25 02:22, Balbir Singh wrote: >>> Unmapped was added as a parameter to __folio_split() and related >>> call sites to support splitting of folios already in the midst >>> of a migration. This special case arose for device private folio >>> migration since during migration there could be a disconnect between >>> source and destination on the folio size. >> >> Didn't I already comment that the subject should start with "mm/huge_memory: introduce ..." ? >> > > Yeah.. the .c in the prefix is not desirable, I missed that in the subject line > >> Yes I did: https://lore.kernel.org/all/048134fd-6a3d-4a6c-a2eb-9a9911c3b35f@kernel.org/ >> >> You know, I'm a busy man, can you *please* >> >> * take better care of addressing all previous comments? >> * wait more than 12 h after asking a question before you resend? >> > > I think addressed most of it, I missed the subject line, but in general addressed > > 1. Using folio_split_ as the prefix to split functions, the main function is called folio_split_unmapped and the helper name was suggested by Zi to be __folio_freeze_and_split_unmapped() and it sounded better than what I had __folio_split_unmapped() or even __folio_split_freeze_unmapped() > 2. Got rid of _to_order() as the function suffix > > Do you have any more outstanding comments that I missed? I'll take a look at v2 now given that I was distracted for 2 days :( -- Cheers David