Re: [PATCH 1/4] sched / idle: Move the default idle call code to a separate function

Rafael J. Wysocki
2015-05-04T20:43:36Z

On Monday, May 04, 2015 04:22:45 PM Peter Zijlstra wrote:
> On Mon, May 04, 2015 at 03:56:24PM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Move the code under the "use_default" label in cpuidle_idle_call()
> > into a separate (new) function.
> >
> > This just allows the subsequent changes to be more stratightforward.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > ---
> > kernel/sched/idle.c | 42 +++++++++++++++++++++++-------------------
> > 1 file changed, 23 insertions(+), 19 deletions(-)
> >
> > Index: linux-pm/kernel/sched/idle.c
> > ===================================================================
> > --- linux-pm.orig/kernel/sched/idle.c
> > +++ linux-pm/kernel/sched/idle.c
> > @@ -67,6 +67,17 @@ void __weak arch_cpu_idle(void)
> > local_irq_enable();
> > }
> >
> > +static void default_idle_call(void) {
>
> Please put opening brace of function on a new line.

Ah that's weird. I wonder why I haven't noticed this myself.

Rafael