From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933444AbcIRMzb (ORCPT ); Sun, 18 Sep 2016 08:55:31 -0400 Received: from mout.web.de ([212.227.17.12]:61419 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756172AbcIRMz0 (ORCPT ); Sun, 18 Sep 2016 08:55:26 -0400 Subject: [PATCH 4/6] firmware-qemu_fw_cfg: Improve a size determination in fw_cfg_build_symlink() To: qemu-devel@nongnu.org, Gabriel Somlo , "Michael S. Tsirkin" References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <24c61c19-c696-919b-8c4c-7e42d8ed5940@users.sourceforge.net> Date: Sun, 18 Sep 2016 14:55:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:CN/+kDtJXLUCrt2RGeKLEHdaN5qwMrm5no6irTqiq3taZKhtM+2 5WOfWa0oagotNwJYTa+0qIb2exCbtWwWH+7zO/RNdODfq/Jsprt7ObVJU4GJcK6I963kACA f8PU+ejkqQUyCxPuB308wd9Nta0TznKpvjknjN6MfUmKH1aKAxhgTaml/A4fG0UUpAyNxSP 4xtOUq8L5kSsX0XtWKRmA== X-UI-Out-Filterresults: notjunk:1;V01:K0:5oS2qMzH52w=:F22aszvpLRv1/F8696QyM6 L3D5UKIwI3YEongmgNpNEX9UvGI9SRGkzdt8vRaqf2hpVBsn4G/Y/05kXck4BTdza9F4iEuHl E6O796w1qi1s02BEBLprAWG6zrAROldavEbfe3xgcuXljp+fdo4OLNQ0vxzhoAyK4XR3dCAWz soLGz2qRh6i0o5SboCS4g8+EsN0KtfMN7Dm79sHO8ZevSVftqXzFN6NmTdQYCXA5I37Ms8Gna zezBGo99+sGcwkrpvEutlS0jeM7RESfg3t8V2GBUs/2ogqYyUND6TtOqd/iIAw17jW8h96FVg rQKdsvURM2FW09eiE4bJiK5Ka9QwKt6toUzVmbbkNVXUygbCnYh5cV01dcfFYg3kuTZF4gfdg 3SrVa25ALkei27ZDOK+f02MgiSqgyK1DoeMBsxMntHt2bahiNkIUAH9gXslZbN1J8f8pZamiA GkdgBgH2/soqSxMSdIl3GCHBGBzk5zSKo6hGUKHnZN/nv8af2xXsijZMRqvqDZ5kcsLSBn7pA HSlOOu6KHbmwgqNGW1RWaHUNVj4/LfKvfBem/8oEkwsS1STvfICDiI7qIBUDKGgCDopFeBDQm jnYUID7RcJwxyb/xJMKq/md7Ez5VaNBhPOyBBsE+6jihK6Ei430CBht/2wwY2ah8DkTyHWhe+ FEfQkGxVv/yVUAxRhNW+HhxE1EUh1RuPTBNb/Hh4QkzFGaJbD0GODkpCL2U0aMT8WAFYrekVA yXYGfiC+UlwvVAXgx+FFC83yYa6h1wakzEmD7gJ4YSjkVfVq+q3kOw6HMZTpNylDSdWYZhFl0 s1+WuOf Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 18 Sep 2016 14:02:02 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/firmware/qemu_fw_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index a834d01..a4b108a 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -399,7 +399,7 @@ static int fw_cfg_build_symlink(struct kset *dir, dir = to_kset(ko); } else { /* create new subdirectory kset */ - subdir = kzalloc(sizeof(struct kset), GFP_KERNEL); + subdir = kzalloc(sizeof(*subdir), GFP_KERNEL); if (!subdir) { ret = -ENOMEM; break; -- 2.10.0