From: Jesper Dangaard Brouer <hawk@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
hkelam@marvell.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org,
alexander.duyck@gmail.com, ilias.apalodimas@linaro.org,
linyunsheng@huawei.com,
Alexander Lobakin <aleksander.lobakin@intel.com>
Subject: Re: [PATCH v2 net] octeontx2-pf: fix page_pool creation fail for rings > 32k
Date: Wed, 23 Aug 2023 09:14:15 +0200 [thread overview]
Message-ID: <24f2dd3e-fb00-894b-0cdc-4ad1e4345a06@kernel.org> (raw)
In-Reply-To: <20230823025325.2499289-1-rkannoth@marvell.com>
On 23/08/2023 04.53, Ratheesh Kannoth wrote:
> octeontx2 driver calls page_pool_create() during driver probe()
> and fails if queue size > 32k. Page pool infra uses these buffers
> as shock absorbers for burst traffic. These pages are pinned down
> over time as working sets varies, due to the recycling nature
> of page pool, given page pool (currently) don't have a shrinker
> mechanism, the pages remain pinned down in ptr_ring.
> Instead of clamping page_pool size to 32k at
> most, limit it even more to 2k to avoid wasting memory.
>
> This have been tested on octeontx2 CN10KA hardware.
> TCP and UDP tests using iperf shows no performance regressions.
>
> Fixes: b2e3406a38f0 ("octeontx2-pf: Add support for page pool")
> Suggested-by: Alexander Lobakin<aleksander.lobakin@intel.com>
> Reviewed-by: Sunil Goutham<sgoutham@marvell.com>
> Signed-off-by: Ratheesh Kannoth<rkannoth@marvell.com>
LGTM
Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
next prev parent reply other threads:[~2023-08-23 7:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 2:53 [PATCH v2 net] octeontx2-pf: fix page_pool creation fail for rings > 32k Ratheesh Kannoth
2023-08-23 7:14 ` Jesper Dangaard Brouer [this message]
2023-08-23 10:12 ` Alexander Lobakin
2023-08-24 2:40 ` [EXT] " Ratheesh Kannoth
-- strict thread matches above, loose matches on Subject: below --
2023-08-16 9:07 Ratheesh Kannoth
2023-08-16 12:44 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24f2dd3e-fb00-894b-0cdc-4ad1e4345a06@kernel.org \
--to=hawk@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox