Re: [PATCH 02/13] uapi: General notification ring definitions [ver #4]

David Howells
2019-06-13T15:13:16Z

Randy Dunlap <rdunlap@infradead.org> wrote:

> What is the problem with inline functions in UAPI headers?

It makes compiler problems more likely; it increases the potential for name
collisions with userspace; it makes for more potential problems if the headers
are imported into some other language; and it's not easy to fix a bug in one
if userspace uses it, just in case fixing the bug breaks userspace.

Further, in this case, the first of Darrick's functions (calculating the
length) is probably reasonable, but the second is not. It should crank the
tail pointer and then use that, but that requires

> >> Also, weird multiline comment style.
> >
> > Not really.
>
> Yes really.

No. It's not weird. If anything, the default style is less good for several
reasons. I'm going to deal with this separately as I need to generate some
stats first.

David