From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933813AbcKVVPo (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Nov 2016 16:15:44 -0500
Received: from mout.kundenserver.de ([212.227.17.10]:62745 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933754AbcKVVPn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Nov 2016 16:15:43 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Ray Jui <ray.jui@broadcom.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        Jon Mason <jonmason@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com, Oza Oza <oza.oza@broadcom.com>,
        "Dmitry V. Krivenok" <krivenok.dmitry@gmail.com>,
        linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: iproc: avoid maybe-uninitialized warning
Date: Tue, 22 Nov 2016 22:15:08 +0100
Message-ID: <2504851.C6gOdhdaGF@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <31c4c52b-3de5-2277-7a44-2a4231531074@broadcom.com>
References: <20161122141844.1655574-1-arnd@arndb.de> <20161122141844.1655574-2-arnd@arndb.de> <31c4c52b-3de5-2277-7a44-2a4231531074@broadcom.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:HH2QJ/3KHbKmcKkET4Vge2EZWFdhD18T5p7QThswj+lZaXZB53s
 IyDfqLJcYDgbt5iv30TXIz0INca36oKRcEG4I1zqtUsBhWOBEr7VaHCrQDd5G7Z2LiG0GQJ
 WR9HlFyUT2RX9qGB16VSCZa1bZfXmjYCxyjYlTipsrAJKj+ffGYni1xydmMIN3R4MTiR/iN
 rwgE7tlih6M1QOMqmozxQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:NE8PUOI72TI=:t4wpQoy/IrHQrwAd5g311g
 A09r6apOBImnianp4NvsO5eMebi3W1QaoSyR3Retgj0F4ILFPMp61o80Qr4Yv1jOORnXwUEj6
 chXXtayg0ibNwZ15eIXBVh762RFz8pX8c36iEL9pThVESmyqW6YQWmVhhC+WRkKbPjf40RZLf
 FAq81c1XbxIzpBY+VSfktwBJdJc9XApMBj3ibBhavzEpiieFK4DXgEtZcUcrJ8IC/id2z5ByE
 5XXYnLJUqQKC7qnF+yhs0WCRfmUQY6BgrwgYa0MUiG+yQ95w8XywGzIMkX8NTB4PnllaK3KZ8
 vteqDLlTEA9HZrMq4wCFTqQl7Jo7mBce3tgJuprCf3RGI6pIHnm2/lPVTvg9Jk+eoDXhDpFC1
 cuBOk0D5tXqU7XYixr0Dd6peBJHxBndHGCUF+wZOlyDREFwKf53RWZN7VtwHKvr3ahdHGrSE8
 Zyre4TwRnPXUsgmJIDR0g9L/NoWnPH5AH/5SiBEa/toKeqWrE5qR+RvQVKE33yCuAmHRQwFyE
 ptn6XzlyghEz+v5cnT7xlE7QR4d3imHdLx2bRvFJ/hGsa+Y0wwlA+aPGE4PRnxIh4VsPQXBrL
 /I7vQHDdbXJVL23NJlZIG1J4nFzIGD06CJbwvKUllgQxlALNxiXjd/t/HfxDRqO2IW9S5SHOC
 fAduMKi+N/2m16TJSRMcDUG80MuiV5hvVHCSvBWxGSgbCgFi7zsJ9NBUpog8smzuFmKLFCcTw
 NjKPUyz2WTaoL48r
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, November 22, 2016 9:45:24 AM CET Ray Jui wrote:
> > diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c
> > index 857ff5198317..0359569c8d78 100644
> > --- a/drivers/pci/host/pcie-iproc.c
> > +++ b/drivers/pci/host/pcie-iproc.c
> > @@ -936,6 +936,7 @@ static int iproc_pcie_setup_ib(struct iproc_pcie *pcie,
> >  
> >               }
> >       }
> > +     ret = -EINVAL;
> >  err_ib:
> >       dev_err(dev, "unable to configure inbound mapping\n");
> >       dev_err(dev, "axi %pap, pci %pap, res size %pap\n",
> > 
> 
> This change is good, but in my opinion, a further improvement for
> clarity would be to initialize 'ret' to -EINVAL in the beginning of this
> function when 'ret' is declared. What do you think?
> 

I never do that, see https://rusty.ozlabs.org/?p=232 for a great
explanation about why.

	Arnd